Rewrite limitations section, minor fixes to unimplemented functions#427
Merged
Lorak-mmk merged 5 commits intoscylladb:masterfrom Feb 25, 2026
Merged
Rewrite limitations section, minor fixes to unimplemented functions#427Lorak-mmk merged 5 commits intoscylladb:masterfrom
Lorak-mmk merged 5 commits intoscylladb:masterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the project’s “Limitations” documentation to better reflect the current state of the wrapper driver and adjusts the public/deleted C API surface to match that documentation.
Changes:
- Rewrites the README limitations section with more structured grouping and rationale/links.
- Removes the wrapper implementation and Rust API re-export for
cass_cluster_set_queue_size_event(previously a no-op). - Reorganizes C header declarations by moving several “not implemented / deleted” APIs out of
cassandra.hintocassandra_deleted_functions.h, and movingcass_cluster_set_use_hostname_resolutionintocassandra.h.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| scylla-rust-wrapper/src/cluster.rs | Removes the no-op cass_cluster_set_queue_size_event symbol from the Rust wrapper. |
| scylla-rust-wrapper/src/api.rs | Stops re-exporting cass_cluster_set_queue_size_event from the Rust API module. |
| include/cassandra_deleted_functions.h | Moves/collects additional “deleted/unimplemented” API declarations here; removes hostname-resolution declaration from this header. |
| include/cassandra.h | Adds cass_cluster_set_use_hostname_resolution to the public header and removes several raw metadata/“custom” declarations. |
| README.md | Replaces the old limitations table/list with an expanded, categorized limitations section and issue links. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This function was deprecated and no-op in cpp-driver. We removed it from cassandra.h before, so it makes no sense to keep it.
We are not planning to implement those, or any other function related to custom types. Others were already moved to unimplemented, this one was forgotten.
Reasoning for removal was imo flawed because of misleading name. We should make sure that we want to remove this. Relevant issue: scylladb#426
We do not plan to implement them.
Now it describes all functions that were present in original cassandra.h, but are not implemented in our driver. Description is split into categories, and each category is described, with links to relevant issue.
bff5997 to
7579adf
Compare
Contributor
Author
|
Fixed typos, rebased on master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR rewrites limitations section in README, to make sure it is complete and correct.
It also fixes some problems I found when doing that - see specific commits for more info.
Now that driver 1.0 is released, I believe it is important to have a comprehensive section about limitations - it will be useful for migrating users.
I used a LLM-coded script to find functions present in cassandra.h, but not in library (and vice-versa). Here it is, maybe it will be useful in the future:
Pre-review checklist
I have implemented Rust unit tests for the features/changes introduced.I have enabled appropriate tests inMakefilein{SCYLLA,CASSANDRA}_(NO_VALGRIND_)TEST_FILTER.I added appropriateFixes:annotations to PR description.