4.x: Adjust BasicLoadBalancingPolicy#getReplicas
#405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bouncheck
force-pushed
the
scylla-4.x-metadata-api
branch
from
98ebc5f to
6743ae4
Compare
Bouncheck
changed the title
getReplicas callBasicLoadBalancingPolicy#getReplicas
Bouncheck
force-pushed
the
scylla-4.x-metadata-api
branch
2 times, most recently
from
5fc84f2 to
23a9d93
Compare
Extends schema related classes with methods for querying scylla_keyspaces in order to determine whether keyspace is tablets-enabled. Adjusts schema queries tests and several other integration tests that mock responses from system tables. Adds `isUsingTablets()` and `setUsingTablets()` to KeyspaceMetadata.
|
Rebased |
dkropachev
requested changes
Jan 13, 2025
.../main/java/com/datastax/oss/driver/internal/core/loadbalancing/BasicLoadBalancingPolicy.java
Outdated
Show resolved
Hide resolved
Bouncheck
force-pushed
the
scylla-4.x-metadata-api
branch
from
23a9d93 to
2048df7
Compare
dkropachev
requested changes
Jan 14, 2025
.../main/java/com/datastax/oss/driver/internal/core/loadbalancing/BasicLoadBalancingPolicy.java
Outdated
Show resolved
Hide resolved
Bouncheck
force-pushed
the
scylla-4.x-metadata-api
branch
from
2048df7 to
d19ef94
Compare
Modifies the getReplicas method to do the tablet lookup if and only if the keyspace metadata indicates that it's a tablets-based keyspace. Otherwise refer to the token map. Previous behavior was to try tablet map lookup first regardless of the keyspace configuration.
dkropachev
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unlike in 3.x this
getReplicasis located inBasicLoadBalancingPolicy.The keyspace and table information is passed through the
Requestargument, so there is no need to extend that part.Those things aside, the behavior should be now in line with the description of #379 .