Make Uuids
have better random distribution
#494
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit
Uuids
used to initiateRandom
at point when it needs a random number.Not only it is not efficient it also produced bad distribution which resulted in
should_generate_unique_random_uuids_Random
to fail, due to inability ofUuids::random
generate unique vales.I have tested it with:
Which was failing after 100 iterations before fix and never failed after.