Make Uuids have better random distribution#494
Merged
dkropachev merged 2 commits intoscylladb:scylla-4.xfrom Apr 4, 2025
Merged
Make Uuids have better random distribution#494dkropachev merged 2 commits intoscylladb:scylla-4.xfrom
Uuids have better random distribution#494dkropachev merged 2 commits intoscylladb:scylla-4.xfrom
Conversation
6d21590 to
9891e31
Compare
Uuids have better random distribution
Bouncheck
suggested changes
Apr 4, 2025
Bouncheck
left a comment
There was a problem hiding this comment.
Docs do not reflect changes.
I think current master is good enough. I've seen this test fail only once so far in all those years.
Before this commit `Uuids` used to initiate `Random `at the point when it needs a random number. Not only it is not effecient it also produced bad distribution which resulted in `should_generate_unique_random_uuids_Random` to fail, due to inability of `Uuids::random `generate unique vales.
Before this commit it used `random.nextBytes` which made it generate an `int` and crop it to `byte`, since it is quasi random, it produces bad distribution and lead to have more UUID collisions.
7a41ee5 to
7bc5cfc
Compare
Author
Thanks for pointing that out, I have moved it to use TrheadLocalRandom, please take a look |
Bouncheck
approved these changes
Apr 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this commit
Uuidsused to initiateRandomat point when it needs a random number.Not only it is not efficient it also produced bad distribution which resulted in
should_generate_unique_random_uuids_Randomto fail, due to inability ofUuids::randomgenerate unique vales.I have tested it with:
Which was failing after 100 iterations before fix and never failed after.