Skip to content

4.x: Fix tablet update for non-select queries #499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 7, 2025

Conversation

dkropachev
Copy link
Collaborator

@dkropachev dkropachev commented Apr 5, 2025

Before fix:

java.lang.AssertionError: Found queries that got no tablet info: 
Statement DELETE_CK_CONCRETE_PREPARED on session REGULAR did not trigger session tablets update
Statement INSERT_CK_CONCRETE_PREPARED on session REGULAR did not trigger session tablets update
Statement UPDATE_PREPARED on session REGULAR did not trigger session tablets update
Statement INSERT_PREPARED on session REGULAR did not trigger session tablets update
Statement DELETE_PREPARED on session REGULAR did not trigger session tablets update
Statement UPDATE_CK_CONCRETE_PREPARED on session REGULAR did not trigger session tablets update
Statement UPDATE_NO_KS_PREPARED on session USE_KEYSPACE did not trigger session tablets update
Statement DELETE_CK_CONCRETE_PREPARED on session USE_KEYSPACE did not trigger session tablets update
Statement INSERT_NO_KS_PREPARED on session USE_KEYSPACE did not trigger session tablets update
Statement INSERT_CK_CONCRETE_PREPARED on session USE_KEYSPACE did not trigger session tablets update
Statement UPDATE_PREPARED on session USE_KEYSPACE did not trigger session tablets update
Statement INSERT_PREPARED on session USE_KEYSPACE did not trigger session tablets update
Statement DELETE_PREPARED on session USE_KEYSPACE did not trigger session tablets update
Statement DELETE_NO_KS_PREPARED on session USE_KEYSPACE did not trigger session tablets update
Statement UPDATE_CK_CONCRETE_PREPARED on session USE_KEYSPACE did not trigger session tablets update
Statement UPDATE_NO_KS_PREPARED on session WITH_KEYSPACE did not trigger session tablets update
Statement DELETE_CK_CONCRETE_PREPARED on session WITH_KEYSPACE did not trigger session tablets update
Statement INSERT_NO_KS_PREPARED on session WITH_KEYSPACE did not trigger session tablets update
Statement INSERT_CK_CONCRETE_PREPARED on session WITH_KEYSPACE did not trigger session tablets update
Statement UPDATE_PREPARED on session WITH_KEYSPACE did not trigger session tablets update
Statement INSERT_PREPARED on session WITH_KEYSPACE did not trigger session tablets update
Statement DELETE_PREPARED on session WITH_KEYSPACE did not trigger session tablets update
Statement DELETE_NO_KS_PREPARED on session WITH_KEYSPACE did not trigger session tablets update
Statement UPDATE_CK_CONCRETE_PREPARED on session WITH_KEYSPACE did not trigger session tablets update

Fixes: #500

@dkropachev dkropachev force-pushed the dk/4.x-fix-tablet-update branch from 83cf11d to 0af3806 Compare April 6, 2025 15:28
@dkropachev dkropachev changed the title 4.x: Fix tablet update for non-update queries on session with no keyspace 4.x: Fix tablet update for non-select queries on session with no keyspace Apr 6, 2025
@dkropachev dkropachev changed the title 4.x: Fix tablet update for non-select queries on session with no keyspace 4.x: Fix tablet update for non-select queries Apr 6, 2025
@dkropachev dkropachev requested a review from Bouncheck April 6, 2025 22:52
@dkropachev dkropachev force-pushed the dk/4.x-fix-tablet-update branch 2 times, most recently from 33b8cbf to 1429983 Compare April 7, 2025 04:19
@dkropachev
Copy link
Collaborator Author

dkropachev commented Apr 7, 2025

By some reasonTabletMapSchemaChangesIT start failing, diggin into it.

@dkropachev dkropachev force-pushed the dk/4.x-fix-tablet-update branch from 1429983 to fcbc822 Compare April 7, 2025 11:27
@dkropachev
Copy link
Collaborator Author

Regarding TabletMapSchemaChangesIT, failure not related to this fix, there is another bug somewhere else.
Most-likely it is #505, let's merge that one, rebase and see if it passes.

@dkropachev dkropachev requested a review from Bouncheck April 7, 2025 11:29
@dkropachev dkropachev force-pushed the dk/4.x-fix-tablet-update branch from fcbc822 to 35dd5d9 Compare April 7, 2025 11:54
Goal is to ensure that server provides tablet info and it reaches
session tablet map for every statement possible.
Fixes tablets update for non-select queries
@dkropachev dkropachev force-pushed the dk/4.x-fix-tablet-update branch from 35dd5d9 to 72bc774 Compare April 7, 2025 12:31
@dkropachev
Copy link
Collaborator Author

@Bouncheck , as I guessed failures were fixed by #505

@dkropachev dkropachev merged commit d975001 into scylladb:scylla-4.x Apr 7, 2025
8 of 10 checks passed
@dkropachev dkropachev self-assigned this Apr 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tablets are not updated for every type of query except select
2 participants