Fix BasicLoadBalancingPolicy.getReplica empty partitioner #503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bouncheck
approved these changes
Apr 7, 2025
core/src/main/java/com/datastax/oss/driver/api/core/metadata/TokenMap.java
Outdated
Show resolved
Hide resolved
dkropachev
force-pushed
the
dk/fix-get-replicas-for-tablets
branch
2 times, most recently
from
9c085de to
9bc2bf0
Compare
Queries getting paritioner set either from user, or when statement is being built against cdc tablet. In other cases statement does not get any partitioner. For proper tablet routing driver needs to calculate token from the key, which needs partitioner, if partitioner is not present driver returns empty replica list. This fix is rather quick-fix. Implementing proper solution that will help with CDC+tablets case, is scheduled at scylladb#502
dkropachev
force-pushed
the
dk/fix-get-replicas-for-tablets
branch
from
9bc2bf0 to
d90c5a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DefaultBoundStatementgetting it's paritioner from when it is being prepared against cdc table.In other cases statement does not get any partitioner.
For proper tablet routing driver needs to calculate token from the key, which needs partitioner, if partitioner is not present driver returns empty replica list.
This PR is rather quick-fix.
Implementing proper solution that will help with CDC+tablets case, is scheduled at #502
Fixes: #497
Tests for fixed functionality to be added in #506