Implement ProtocolFeatureStore#605
Conversation
3380b23 to
a367d0a
Compare
Implement class to store information about all features negotiated.
a367d0a to
245ea63
Compare
245ea63 to
7c9a37f
Compare
Bouncheck
left a comment
There was a problem hiding this comment.
LGTM.
There may be very slight performance hit, probably negligible.
Instead of getting specific features directly the getters will now get whole feature store and then the specific feature from it.
|
I see that two features had method names changed to |
No need to pull this information all the time from the channel. Let's cache it when it is populated to the channel and use it.
I was thinking about the same, |
Implement class to store information about all features negotiated.
The main idea is to have a single place where we store that information, instead of spreading all over channel, and
ProtocolInitHandlerIt is required by #599