-
Notifications
You must be signed in to change notification settings - Fork 20
refactor: Modernize Docker setup and improve connector scripts #199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
refactor: Modernize Docker setup and improve connector scripts #199
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR modernizes the cp-quickstart Docker environment by replacing a custom Dockerfile with the official Confluent Kafka Connect image and improving setup scripts with better compatibility and error handling.
Key changes:
- Replaced custom Dockerfile with official
confluentinc/cp-kafka-connect:8.1.1image using volume mounts for connector JARs - Added auto-detection for both
docker compose(plugin) and legacydocker-composecommands - Changed Scylla cluster name from
scylla-clustertoscylla_clusterfor consistency with topic naming conventions
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| cp-quickstart/docker-compose.yml | Switched to official Confluent image, updated plugin path to use volume mount, and changed cluster name to underscore format |
| cp-quickstart/setup-containers.sh | Added docker compose command detection, REST API readiness checks, and JAR verification logging |
| cp-quickstart/setup-connector.sh | Enhanced with plugin verification, connector update/create logic, and corrected topic naming in examples |
| cp-quickstart/cleanup.sh | Added docker compose command detection for consistency with setup script |
| cp-quickstart/README.md | Updated documentation to reflect new cluster name and topic naming conventions |
| cp-quickstart/Dockerfile.connect | Removed custom Dockerfile as it's replaced by official image with volume mounts |
…ylla CDC Apply suggestions from code review Co-authored-by: Copilot <[email protected]> Co-authored-by: Dmitry Kropachev <[email protected]>
7e09857 to
7af1bb6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated 5 comments.
Apply suggestions from code review Co-authored-by: Copilot <[email protected]>
14b091f to
713b7b4
Compare
Modernize cp-quickstart Docker Compose and Scripts
This PR updates the
cp-quickstartenvironment for the Scylla CDC Source Connector to improve compatibility, reliability, and user experience with modern Docker Compose and Confluent images.Key changes
/usr/share/confluent-hub-componentsand setCONNECT_PLUGIN_PATHaccordingly.SCYLLA_CLUSTER_NAMEtoscylla_cluster(underscore, not dash) for consistency with topic naming and documentation (fixes Avro warning).docker compose(plugin) or legacydocker-compose.scylla_cluster.demo_keyspace.users.scylla_cluster(underscore).Motivation
docker composeanddocker-compose.Testing