-
Notifications
You must be signed in to change notification settings - Fork 104
test(per table hints): Added a test for per table hints #10965
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
test(per table hints): Added a test for per table hints #10965
Conversation
Running tests once its completed it update job url |
identified changes in generated codediff found by running:
|
How is the test evaluated? Manually from grafana? |
b2b828b
to
352063b
Compare
Yes, manually from grafana keyspace charts. If this job runs against non per-tablet hints branch, job will fail with syntax error. |
Please mention it in the docstring for both config and pipeline so it is clear for anyone EDIT: Also please add correct backport labels |
489fff3
to
e2ae99d
Compare
e2ae99d
to
b1f0ceb
Compare
Test per table hints expected_data_size_in_gb option with GrowShrinkNemesis Signed-off-by: Lakshmipathi.Ganapathi <[email protected]>
b1f0ceb
to
9508a1b
Compare
@scylladb/qa-maintainers please review and merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't this pipeline/test config go under features
dir?
# to test hint behavior during cluster scaling operations. | ||
# | ||
# Test Evaluation: | ||
# - Results must be evaluated manually from Grafana keyspace charts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need instructions what to evaluate
if instructions are provided - can it be automated?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree on the instructions, but given what we are trying to do and how uncertain the feature is (they are hints, so not 100% accurate) I think it is not worth the effort to automate it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have prometheus with metrics and if we expect some specific value ranges we can verify it.
Or if not verify then, at least, report to Argus to the "results" section.
Test per table hints expected_data_size_in_gb option with GrowShrinkNemesis
Testing
PR pre-checks (self review)
backport
labelsReminders
sdcm/sct_config.py
)unit-test/
folder)