Skip to content

fix(get_branched_repo): handle properly the source available versions #11392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 15, 2025

Conversation

vponomaryov
Copy link
Contributor

@vponomaryov vponomaryov commented Jul 14, 2025

It is needed when we specify versions like branch-2025.3:latest.
Without this fix we get following error (scylla-2025.3/tier1/jepsen-all-test#5):

  Traceback (most recent call last):
    File "<path-to>/sdcm/tester.py", line 195, in wrapper
      return method(*args, **kwargs)
    File "<path-to>/sdcm/utils/decorators.py", line 122, in inner
      res = func(*args, **kwargs)
    File "<path-to>/sdcm/tester.py", line 875, in setUp
      self._init_params()
    File "<path-to>/sdcm/tester.py", line 693, in _init_params
      self.params = init_and_verify_sct_config()
    File "<path-to>/sdcm/sct_config.py", line 2974, in init_and_verify_sct_config
      sct_config = SCTConfiguration()
    File "<path-to>/sdcm/sct_config.py", line 2031, in __init__
      self['scylla_repo'] = find_scylla_repo(scylla_version, dist_type, dist_version)
    File "<path-to>/sdcm/utils/version_utils.py", line 821, in find_scylla_repo
      raise ValueError(f"repo for scylla version {scylla_version} wasn't found")
  ValueError: repo for scylla version branch-2025.3:latest wasn't found

Testing

  • [ ]

PR pre-checks (self review)

  • I added the relevant backport labels
  • I didn't leave commented-out/debugging code

Reminders

  • Add New configuration option and document them (in sdcm/sct_config.py)
  • Add unit tests to cover my changes (under unit-test/ folder)
  • Update the Readme/doc folder relevant to this change (if needed)

@vponomaryov
Copy link
Contributor Author

Looks like the utils/get_supported_scylla_base_versions.py behaves incorrectly with this fix.

@fruch
Copy link
Contributor

fruch commented Jul 14, 2025

@vponomaryov

I wouldn't go that path of changing this function logic, it's being used in all kind of place no in a way you might think.

I would recommend applying the fix within get_branched_repo, seems like we didn't used it in a while

@vponomaryov vponomaryov changed the title fix(is_enterprise): handle properly the source available versions fix(get_branched_repo): handle properly the source available versions Jul 15, 2025
@vponomaryov
Copy link
Contributor Author

@fruch , @soyacz
Done

soyacz
soyacz previously approved these changes Jul 15, 2025
Copy link
Contributor

@soyacz soyacz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

It is needed when we specify versions like "branch-2025.3:latest".
Without this fix we get following error:

  Traceback (most recent call last):
    File "<path-to>/sdcm/tester.py", line 195, in wrapper
      return method(*args, **kwargs)
    File "<path-to>/sdcm/utils/decorators.py", line 122, in inner
      res = func(*args, **kwargs)
    File "<path-to>/sdcm/tester.py", line 875, in setUp
      self._init_params()
    File "<path-to>/sdcm/tester.py", line 693, in _init_params
      self.params = init_and_verify_sct_config()
    File "<path-to>/sdcm/sct_config.py", line 2974, in init_and_verify_sct_config
      sct_config = SCTConfiguration()
    File "<path-to>/sdcm/sct_config.py", line 2031, in __init__
      self['scylla_repo'] = find_scylla_repo(scylla_version, dist_type, dist_version)
    File "<path-to>/sdcm/utils/version_utils.py", line 821, in find_scylla_repo
      raise ValueError(f"repo for scylla version {scylla_version} wasn't found")
  ValueError: repo for scylla version branch-2025.3:latest wasn't found
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants