-
Notifications
You must be signed in to change notification settings - Fork 104
fix(get_branched_repo): handle properly the source available versions #11392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Looks like the |
I wouldn't go that path of changing this function logic, it's being used in all kind of place no in a way you might think. I would recommend applying the fix within |
46a01d2
to
96aef2d
Compare
96aef2d
to
d44fab6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
It is needed when we specify versions like "branch-2025.3:latest". Without this fix we get following error: Traceback (most recent call last): File "<path-to>/sdcm/tester.py", line 195, in wrapper return method(*args, **kwargs) File "<path-to>/sdcm/utils/decorators.py", line 122, in inner res = func(*args, **kwargs) File "<path-to>/sdcm/tester.py", line 875, in setUp self._init_params() File "<path-to>/sdcm/tester.py", line 693, in _init_params self.params = init_and_verify_sct_config() File "<path-to>/sdcm/sct_config.py", line 2974, in init_and_verify_sct_config sct_config = SCTConfiguration() File "<path-to>/sdcm/sct_config.py", line 2031, in __init__ self['scylla_repo'] = find_scylla_repo(scylla_version, dist_type, dist_version) File "<path-to>/sdcm/utils/version_utils.py", line 821, in find_scylla_repo raise ValueError(f"repo for scylla version {scylla_version} wasn't found") ValueError: repo for scylla version branch-2025.3:latest wasn't found
d44fab6
to
bf1b9b2
Compare
It is needed when we specify versions like
branch-2025.3:latest
.Without this fix we get following error (scylla-2025.3/tier1/jepsen-all-test#5):
Testing
PR pre-checks (self review)
backport
labelsReminders
sdcm/sct_config.py
)unit-test/
folder)