fix(pull_image): correctly check if node is a docker container #11393
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimakr
added
test-integration
|
seems like this is the only failure left in the integration tests: and it's known one related to HDR handling that we need to chase down |
fruch
added
test-provision-aws
|
added provision test for aws and gce, for making sure it doesn't regress those |
dimakr
added
test-provision-gce
Previously, the `docker_hub_login` method in `RemoteDocker.pull_image` was incorrectly using `node.is_docker` as a property. Since `is_docker` is implemented as a method, accessing it without parentheses always evaluated to True value. This change ensures `node.is_docker()` is properly called, so the `docker_hub_login` behaves as intended.
dimakr
force-pushed
the
fix_docker_hub_login
branch
from
28764e3 to
5d88bc0
Compare
|
@fruch Had to re-trigger CI as gce provision test failed the first time (the test itself passed, but pipeline reported a connection error for builder instance). On rerun both tests pass. Test integration tests are passing now, except for the |
This was referenced Jul 15, 2025
scylladbbot
added
backport/2025.3-done
backport/2025.2-done
backport/2025.1-done
and removed
backport/2025.3
backport/2025.2
backport/2025.1
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the
docker_hub_loginmethod inRemoteDocker.pull_imagewas incorrectly usingnode.is_dockeras a property. Sinceis_dockeris implemented as a method, accessing it without parentheses always evaluated to True value.This change ensures
node.is_docker()is properly called, so thedocker_hub_loginbehaves as intended.Testing
PR pre-checks (self review)
backportlabelsReminders
sdcm/sct_config.py)unit-test/folder)