images: add netcat-openbsd package #683
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As it required by the cloud team Fixes: scylladb#682
mykaul
reviewed
Apr 3, 2025
| @@ -79,7 +79,7 @@ if __name__ == '__main__': | |||
| run('apt-get update --allow-insecure-repositories -y', shell=True, check=True) | |||
| run('apt-get full-upgrade -y', shell=True, check=True) | |||
| run('apt-get purge -y apport python3-apport fuse', shell=True, check=True) | |||
| run('apt-get install -y systemd-coredump vim.tiny nmap ncat tmux jq python3-boto xfsprogs mdadm initramfs-tools ethtool vim-nox sysstat cpufrequtils nload htop traceroute dnsutils net-tools', shell=True, check=True) | |||
| run('apt-get install -y systemd-coredump vim.tiny nmap ncat tmux jq python3-boto xfsprogs mdadm initramfs-tools ethtool vim-nox sysstat cpufrequtils nload htop traceroute dnsutils net-tools netcat-openbsd', shell=True, check=True) | |||
There was a problem hiding this comment.
Suggested change
| run('apt-get install -y systemd-coredump vim.tiny nmap ncat tmux jq python3-boto xfsprogs mdadm initramfs-tools ethtool vim-nox sysstat cpufrequtils nload htop traceroute dnsutils net-tools netcat-openbsd', shell=True, check=True) | |
| run('apt-get install -y systemd-coredump vim.tiny nmap tmux jq python3-boto xfsprogs mdadm initramfs-tools ethtool vim-nox sysstat cpufrequtils nload htop traceroute dnsutils net-tools netcat-openbsd', shell=True, check=True) |
There was a problem hiding this comment.
Wait. Now that I think about it - if we do have ncat already, why do we need netcat? @d-helios ?
There was a problem hiding this comment.
I'd like to understand it better, but for now, please do. We'll get rid of ncat if we don't need it in the future.
Annamikhlin
approved these changes
Apr 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it required by the cloud team
Fixes: #682
Testing