net: functions describing ssl connection #2651
Draft
+58
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptrsmrn
added a commit
to ptrsmrn/scylladb
that referenced
this pull request
Feb 21, 2025
Depends on scylladb/seastar#2651 Missing columns have been present since probably forever - they were added to the schema but never assigned any value: ``` cqlsh> select * from system.clients; ------------------+------------------------ ... hostname | null ... ssl_cipher_suite | null ssl_enabled | null ssl_protocol | null ... ``` This patch sets values of these columns: - `hostname` is always filled in, - with TLS connection, remaining 3 TSL-related fields are filled in, - without TLS, `ssl_enabled` is set to `false` and other columns are `null`. Fixes: scylladb#9216
Needed in scylladb/scylladb#22961 3 methods have been added in order to expose more information on the characteristics of TLS socket connection.
ptrsmrn
force-pushed
the
set_system_clients_ssl_options
branch
from
5b40a0c to
582a991
Compare
ptrsmrn
changed the title
KrzaQ
reviewed
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed in scylladb/scylladb#22961
3 methods have been added in order to expose more
information on the characteristics of a TLS socket connection.