Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net: functions describing ssl connection #2651

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ptrsmrn
Copy link

@ptrsmrn ptrsmrn commented Feb 20, 2025

Needed in scylladb/scylladb#22961

3 methods have been added in order to expose more
information on the characteristics of a TLS socket connection.

ptrsmrn added a commit to ptrsmrn/scylladb that referenced this pull request Feb 21, 2025
Depends on scylladb/seastar#2651

Missing columns have been present since probably forever -
they were added to the schema but never assigned any value:
```
cqlsh> select * from system.clients;
------------------+------------------------
...
 hostname         | null
...
 ssl_cipher_suite | null
 ssl_enabled      | null
 ssl_protocol     | null
...
```

This patch sets values of these columns:
- `hostname` is always filled in,
- with TLS connection, remaining 3 TSL-related fields are filled in,
- without TLS, `ssl_enabled` is set to `false` and other columns are
  `null`.

Fixes: scylladb#9216
Needed in scylladb/scylladb#22961

3 methods have been added in order to expose more
information on the characteristics of TLS socket connection.
@ptrsmrn ptrsmrn force-pushed the set_system_clients_ssl_options branch from 5b40a0c to 582a991 Compare February 21, 2025 13:28
@ptrsmrn ptrsmrn changed the title WIP: net: functions describing ssl connection net: functions describing ssl connection Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants