Skip to content

feat: define exclude_pattern per version #1145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 30, 2024

Conversation

dgarcia360
Copy link
Collaborator

@dgarcia360 dgarcia360 commented Jul 19, 2024

Motivation

Closes #1006

How to test

It's challenging to test the changes in this PR, but I can write a guide if necessary or go through the steps in a call.

I've tested the changes against the enterprise repo.

Next steps

After merging, I'll release a new version of the multiversion extension, making it possible to define exclude_patterns per version.

@dgarcia360 dgarcia360 marked this pull request as ready for review July 24, 2024 13:42
@dgarcia360 dgarcia360 requested a review from annastuchlik July 24, 2024 13:51
@annastuchlik
Copy link
Collaborator

Let's talk about it in the call, no need to write a guide. Anyway, I'll have to test it directly in the repo after the new theme version is released.

Copy link
Collaborator

@annastuchlik annastuchlik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please merge

@dgarcia360 dgarcia360 merged commit d74b342 into scylladb:master Jul 30, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiversion: configure exclude_patterns per version
2 participants