-
Notifications
You must be signed in to change notification settings - Fork 6
FIx bug from update of packages #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrKeith99
reviewed
Sep 6, 2025
Contributor
MrKeith99
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your work!
I have written some comments. Please let me know if I am not explaining properly.
Btw, we should think about converting the direct_effort_control.py into cpp version in a future. Maybe this time separating it into hpp and cpp.
Co-authored-by: Keith Valentin <[email protected]>
Co-authored-by: Keith Valentin <[email protected]>
Co-authored-by: Keith Valentin <[email protected]>
MrKeith99
reviewed
Sep 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the bug from the current version in
mainbranch. The list of bugs are includedIssues Fixed
install_local.shinsteadib2_interfacerepo url ininstall_local.sh.install_local.sh.int-ball2_isaacsim.launch.pyuse_internal_libstoFalse. Due to the update of IsaacSim-ros_workspaces, the default value of this parameter causes the issue of ros2 bridge extension in Isaacsim.direct_effort_control.py: Change incorrect wrench message type fromWrenchtoWrenchStamped.Testing
Files Changed
README.mdandREADME_JA.md- Version and installation instructions.install_local.sh- ib2_interface's url and rosdep dependencies installation.int-ball2_isaac_sim.launch.py- Wrong package name and update launch configuration.direct_effort_control.py- Message type correction.