Skip to content

Conversation

@TharitSinsunthorn
Copy link
Collaborator

@TharitSinsunthorn TharitSinsunthorn commented Sep 6, 2025

Summary

This PR fixes the bug from the current version in main branch. The list of bugs are included

Issues Fixed

  1. Documentation Updates
  • Updated recommended Isaac Sim version from 4.2 and 4.5
  • Move rosdep command to install_local.sh instead
  1. Installation Script Improvements
  • Fixed the wrong ib2_interface repo url in install_local.sh.
  • Include rosdep depencies installation in install_local.sh.
  1. Launch Configuration Fixes
  • Fixed package name typo in int-ball2_isaacsim.launch.py
  • Set launch configuration for use_internal_libs to False. Due to the update of IsaacSim-ros_workspaces, the default value of this parameter causes the issue of ros2 bridge extension in Isaacsim.
  1. Controller Communication Fix
  • Fixed direct_effort_control.py: Change incorrect wrench message type from Wrench to WrenchStamped.

Testing

  • Colcon build completes successfully.
  • I have checked if the simulation is working fine.
  • I update the corresponding changes to the document.
  • I have checked there is no new generated warnings.

Files Changed

  1. README.mdand README_JA.md - Version and installation instructions.
  2. install_local.sh - ib2_interface's url and rosdep dependencies installation.
  3. int-ball2_isaac_sim.launch.py - Wrong package name and update launch configuration.
  4. direct_effort_control.py - Message type correction.

@TharitSinsunthorn TharitSinsunthorn self-assigned this Sep 6, 2025
@TharitSinsunthorn TharitSinsunthorn added the bug Something isn't working label Sep 6, 2025
Copy link
Contributor

@MrKeith99 MrKeith99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your work!
I have written some comments. Please let me know if I am not explaining properly.
Btw, we should think about converting the direct_effort_control.py into cpp version in a future. Maybe this time separating it into hpp and cpp.

@TharitSinsunthorn TharitSinsunthorn merged commit 276f37d into main Sep 8, 2025
@TharitSinsunthorn TharitSinsunthorn deleted the hotfix/bug_in_main branch September 8, 2025 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants