Skip to content

Add diff printout for ruff format failure #2084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 21, 2024
Merged

Conversation

gsheni
Copy link
Contributor

@gsheni gsheni commented Jun 20, 2024

No description provided.

@gsheni gsheni self-assigned this Jun 20, 2024
@gsheni gsheni requested a review from amontanez24 June 20, 2024 15:56
@gsheni gsheni marked this pull request as ready for review June 20, 2024 15:56
@gsheni gsheni requested a review from a team as a code owner June 20, 2024 15:56
@R-Palazzo
Copy link
Contributor

Hi @gsheni, I noticed that print() statements are no longer raised when running invoke lint. Also running make fix-lint will not remove print statements.

@amontanez24
Copy link
Contributor

Hi @gsheni, I noticed that print() statements are no longer raised when running invoke lint. Also running make fix-lint will not remove print statements.

@gsheni If we can we should fix this to match the behavior of the previous lint rules

@R-Palazzo R-Palazzo self-requested a review June 21, 2024 15:12
@gsheni gsheni merged commit e0ccc94 into main Jun 21, 2024
39 checks passed
@gsheni gsheni deleted the verbose_ruff_printout branch June 21, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants