Skip to content

Add version parameter to the get_metadata function for SingleTableSynthesizers #2491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pvk-developer
Copy link
Member

Resolves #2484
CU-86b4tehv8

@pvk-developer pvk-developer requested a review from a team as a code owner April 28, 2025 15:49
@pvk-developer pvk-developer requested review from gsheni and removed request for a team April 28, 2025 15:49
@sdv-team
Copy link
Contributor

@gsheni
Copy link
Contributor

gsheni commented Apr 28, 2025

@pvk-developer should the target branch be feature/single-table-CAG?

Copy link

codecov bot commented Apr 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.60%. Comparing base (28b2495) to head (9a710a4).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2491   +/-   ##
=======================================
  Coverage   98.60%   98.60%           
=======================================
  Files          59       59           
  Lines        6234     6238    +4     
=======================================
+ Hits         6147     6151    +4     
  Misses         87       87           
Flag Coverage Δ
integration 82.49% <80.00%> (-0.03%) ⬇️
unit 97.51% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pvk-developer
Copy link
Member Author

@pvk-developer should the target branch be feature/single-table-CAG?

I did not point to that branch because we have self._original_metadata and self.metadata in main already, @amontanez24 should I move it ?

@amontanez24
Copy link
Contributor

@pvk-developer should the target branch be feature/single-table-CAG?

I did not point to that branch because we have self._original_metadata and self.metadata in main already, @amontanez24 should I move it ?

Yes, we should point to that feature branch. Can you rebase that feature branch onto main and handle any merge conflicts there?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add 'version' parameter to SingleTableSynthesizer.get_metadata
4 participants