PARSynthesizer: FutureWarnings in groupby.apply and Series.__getitem__ from pandas
#2707
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
R-Palazzo
commented
Oct 6, 2025
| if _is_datetime_type(sequence_index[self._sequence_index]): | ||
| sequence_index[self._sequence_index] = cast_to_datetime64( | ||
| sequence_index[self._sequence_index] | ||
| ).astype(np.int64) |
There was a problem hiding this comment.
Before pandas 2.2, datetime columns stored as object dtypes were silently converted to float dtype. To be consistent with the fill_value used in L330 or L332, the column has to be numerical.
Let me know if this makes sense
frances-h
approved these changes
Oct 6, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2707 +/- ##
=======================================
Coverage 97.00% 97.00%
=======================================
Files 74 74
Lines 7770 7776 +6
=======================================
+ Hits 7537 7543 +6
Misses 233 233
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
pvk-developer
approved these changes
Oct 8, 2025
sdv/sequential/par.py
Outdated
Comment on lines
323
to
325
| diff_series = sequence_index.groupby(self._sequence_key, group_keys=False)[ | ||
| self._sequence_index | ||
| ].transform(lambda s: s.diff().bfill()) |
There was a problem hiding this comment.
Can we not use lambda here and have a function instead ?
R-Palazzo
force-pushed
the
issue-2682-pandas-warning
branch
from
12c9076 to
01d9a0f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #2682
CU-86b6wkybp