Skip to content

[Metadata - CompositeKeys] Validate that primary key columns are unique#2840

Open
pvk-developer wants to merge 4 commits intofeature/metadata-composite-keysfrom
issue-2825-validate-that-primary-key-columns-are-unique
Open

[Metadata - CompositeKeys] Validate that primary key columns are unique#2840
pvk-developer wants to merge 4 commits intofeature/metadata-composite-keysfrom
issue-2825-validate-that-primary-key-columns-are-unique

Conversation

@pvk-developer
Copy link
Member

@pvk-developer pvk-developer commented Mar 10, 2026

Resolves #2825
CU-86b8n8h1h

@pvk-developer pvk-developer self-assigned this Mar 10, 2026
@sdv-team
Copy link
Contributor

sdv-team commented Mar 10, 2026

Task linked: CU-86b8n8h1h SDV - [Metadata composite keys] Validate that primary key columns are unique #2825

@pvk-developer pvk-developer marked this pull request as ready for review March 10, 2026 15:59
@pvk-developer pvk-developer requested a review from a team as a code owner March 10, 2026 15:59
@pvk-developer pvk-developer requested review from fealho and sarahmish and removed request for a team March 10, 2026 15:59
@sdv-team
Copy link
Contributor

sdv-team commented Mar 10, 2026

This Pull Request is not linked to an issue. To ensure our community is able to accurately track resolved issues, please link any issue that will be closed by this PR!

@sdv-team
Copy link
Contributor

sdv-team commented Mar 10, 2026

This Pull Request is not linked to an issue. To ensure our community is able to accurately track resolved issues, please link any issue that will be closed by this PR!

@codecov
Copy link

codecov bot commented Mar 10, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.06%. Comparing base (868be4d) to head (0c77a2a).

Additional details and impacted files 
@@                         Coverage Diff                         @@
##           feature/metadata-composite-keys    #2840      +/-   ##
===================================================================
- Coverage                            98.07%   98.06%   -0.02%     
===================================================================
  Files                                   73       73              
  Lines                                 8278     8284       +6     
===================================================================
+ Hits                                  8119     8124       +5     
- Misses                                 159      160       +1
Flag Coverage Δ
integration 75.61% <71.42%> (-0.02%) ⬇️
unit 97.09% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sdv-team
Copy link
Contributor

sdv-team commented Mar 10, 2026

This Pull Request is not linked to an issue. To ensure our community is able to accurately track resolved issues, please link any issue that will be closed by this PR!

sarahmish
sarahmish reviewed Mar 10, 2026
View reviewed changes
@pvk-developer pvk-developer requested a review from sarahmish March 11, 2026 14:26
@sdv-team
Copy link
Contributor

sdv-team commented Mar 11, 2026

This Pull Request is not linked to an issue. To ensure our community is able to accurately track resolved issues, please link any issue that will be closed by this PR!

fealho
fealho approved these changes Mar 11, 2026
View reviewed changes
tests/unit/metadata/test_metadata.py
assert metadata._multi_table_updated

def test_validate_with_composite_key_that_has_duplicates(self):
"""Test that `validate` will error out if the comoposite key has duplicated columns."""
Copy link
Member

@fealho fealho Mar 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo, comoposite

fealho
fealho reviewed Mar 11, 2026
View reviewed changes
pyproject.toml
"*.ipynb",
".ipynb_checkpoints",
"tasks.py",
"*.md",
Copy link
Member

@fealho fealho Mar 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fealho fealho fealho approved these changes

@sarahmish sarahmish sarahmish approved these changes

Assignees

@pvk-developer pvk-developer

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pvk-developer @sdv-team @fealho @sarahmish