[Metadata Composite Keys] Update set_primary_key docstring#2841
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## feature/metadata-composite-keys #2841 +/- ##
====================================================================
- Coverage 98.07% 75.63% -22.45%
====================================================================
Files 73 73
Lines 8278 8278
====================================================================
- Hits 8119 6261 -1858
- Misses 159 2017 +1858
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fealho
left a comment
fealho
left a comment
There was a problem hiding this comment.
The issue also asks to "update the docstring for SingleTableMetadata.set_primary_key".
| Args: | ||
| table_name (str): | ||
| Name of the table to set the primary key. | ||
| column_name (str, tulple[str]): |
There was a problem hiding this comment.
Typo, tulple
But shouldn't this be a list?
| """Set the primary key of a table. | ||
|
|
||
| Args: | ||
| table_name (str): |
There was a problem hiding this comment.
Wrong order, column_name comes first
| "*.ipynb", | ||
| ".ipynb_checkpoints", | ||
| "tasks.py", | ||
| "*.md", |
|
This Pull Request is not linked to an issue. To ensure our community is able to accurately track resolved issues, please link any issue that will be closed by this PR! |
3 participants
Resolves #2824
CU-86b8n8h1r