Development #724

seanmorley15 · 2025-07-10T03:19:25Z

No description provided.

Fix Dutch translations.

Update nl.json

… code

…nization

…st workflows

…riggers in backend and frontend workflows

…end and frontend workflows

…workflows fix(dependencies): add overrides for esbuild in frontend package.json

… in Trivy workflow

…orkflow

* added-fix-image-deletion * feat(commands): add image cleanup command to find and delete unused files * fix(models): ensure associated AdventureImages are deleted and files cleaned up on Adventure deletion * fix(models): ensure associated Attachment files are deleted and their filesystem cleaned up on Adventure deletion --------- Co-authored-by: ferdousahmed <[email protected]> Co-authored-by: Sean Morley

* Refactor user_id to user in adventures and related models, views, and components - Updated all instances of user_id to user in the adventures app, including models, serializers, views, and frontend components. - Adjusted queries and filters to reflect the new user field naming convention. - Ensured consistency across the codebase for user identification in adventures, collections, notes, and transportation entities. - Modified frontend components to align with the updated data structure, ensuring proper access control and rendering based on user ownership. * Refactor adventure-related views and components to use "Location" terminology - Updated GlobalSearchView to replace AdventureSerializer with LocationSerializer. - Modified IcsCalendarGeneratorViewSet to use LocationSerializer instead of AdventureSerializer. - Created new LocationImageViewSet for managing location images, including primary image toggling and image deletion. - Introduced LocationViewSet for managing locations with enhanced filtering, sorting, and sharing capabilities. - Updated ReverseGeocodeViewSet to utilize LocationSerializer. - Added ActivityTypesView to retrieve distinct activity types from locations. - Refactored user views to replace AdventureSerializer with LocationSerializer. - Updated frontend components to reflect changes from "adventure" to "location", including AdventureCard, AdventureLink, AdventureModal, and others. - Adjusted API endpoints in frontend routes to align with new location-based structure. - Ensured all references to adventures are replaced with locations across the codebase. * refactor: rename adventures to locations across the application - Updated localization files to replace adventure-related terms with location-related terms. - Refactored TypeScript types and variables from Adventure to Location in various routes and components. - Adjusted UI elements and labels to reflect the change from adventures to locations. - Ensured all references to adventures in the codebase are consistent with the new location terminology. * Refactor code structure for improved readability and maintainability * feat: Implement location details page with server-side loading and deletion functionality - Added +page.server.ts to handle server-side loading of additional location info. - Created +page.svelte for displaying location details, including images, visits, and maps. - Integrated GPX file handling and rendering on the map. - Updated map route to link to locations instead of adventures. - Refactored profile and search routes to use LocationCard instead of AdventureCard. * docs: Update terminology from "Adventure" to "Location" and enhance project overview * docs: Clarify collection examples in usage documentation * feat: Enable credentials for GPX file fetch and add CORS_ALLOW_CREDENTIALS setting * Refactor adventure references to locations across the backend and frontend - Updated CategoryViewSet to reflect location context instead of adventures. - Modified ChecklistViewSet to include locations in retrieval logic. - Changed GlobalSearchView to search for locations instead of adventures. - Adjusted IcsCalendarGeneratorViewSet to handle locations instead of adventures. - Refactored LocationImageViewSet to remove unused import. - Updated LocationViewSet to clarify public access for locations. - Changed LodgingViewSet to reference locations instead of adventures. - Modified NoteViewSet to prevent listing all locations. - Updated RecommendationsViewSet to handle locations in parsing and response. - Adjusted ReverseGeocodeViewSet to search through user locations. - Updated StatsViewSet to count locations instead of adventures. - Changed TagsView to reflect activity types for locations. - Updated TransportationViewSet to reference locations instead of adventures. - Added new translations for search results related to locations in multiple languages. - Updated dashboard and profile pages to reflect location counts instead of adventure counts. - Adjusted search routes to handle locations instead of adventures. * Update banner image * style: Update stats component background and border for improved visibility * refactor: Rename AdventureCard and AdventureModal to LocationCard and LocationModal for consistency

* feat(backup): add BackupViewSet for data export and import functionality * Fixed frontend returning corrupt binary data * feat(import): enhance import functionality with confirmation check and improved city/region/country handling * Potential fix for code scanning alert no. 29: Information exposure through an exception Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> * Refactor response handling to use arrayBuffer instead of bytes * Refactor image cleanup command to use LocationImage model and update import/export view to include backup and restore functionality * Update backup export versioning and improve data restore warning message * Enhance image navigation and localization support in modal components * Refactor location handling in Immich integration components for consistency * Enhance backup and restore functionality with improved localization and error handling * Improve accessibility by adding 'for' attribute to backup file input label --------- Co-authored-by: Christian Zäske <[email protected]> Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>

…d fields

vercel · 2025-07-10T03:19:30Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
adventurelog	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 10, 2025 3:19am

.github/workflows/trivy_security_scans.yml

+    name: Trivy Filesystem Scan (Source Code)
+    runs-on: ubuntu-latest
+
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v4
+
+      - name: Scan source code (Filesystem) with Trivy
+        uses: aquasecurity/trivy-action@master
+        with:
+          scan-type: fs
+          scan-ref: .
+          format: table
+          exit-code: 1
+          ignore-unfixed: true
+          severity: CRITICAL,HIGH
+
+  image-scan:


To fix the issue, we will add a permissions block to the workflow. Since the jobs in this workflow primarily involve scanning source code and Docker images, they only require read access to the repository contents. We will set contents: read at the workflow level to apply this permission to all jobs. Additionally, for the image-scan job, which includes an optional login step to the GitHub Container Registry, we will add packages: write permissions at the job level to allow pushing images if needed.

.github/workflows/trivy_security_scans.yml

+    name: Trivy Docker Image Scan (Backend & Frontend)
+    runs-on: ubuntu-latest
+
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v4
+
+      - name: Set up Docker Buildx
+        uses: docker/setup-buildx-action@v3
+
+      # Optional login step (remove if you're not pushing images to GHCR)
+      - name: Login to GitHub Container Registry
+        uses: docker/login-action@v3
+        with:
+          registry: ghcr.io
+          username: ${{ github.actor }}
+          password: ${{ secrets.GITHUB_TOKEN }}
+
+      - name: Build backend Docker image
+        run: docker build -t adventurelog-backend ./backend
+
+      - name: Build frontend Docker image
+        run: docker build -t adventurelog-frontend ./frontend
+
+      - name: Scan backend Docker image with Trivy
+        uses: aquasecurity/trivy-action@master
+        with:
+          image-ref: adventurelog-backend
+          format: table
+          exit-code: 1
+          ignore-unfixed: true
+          severity: CRITICAL,HIGH
+
+      - name: Scan frontend Docker image with Trivy
+        uses: aquasecurity/trivy-action@master
+        with:
+          image-ref: adventurelog-frontend
+          format: table
+          exit-code: 1
+          ignore-unfixed: true
+          severity: CRITICAL,HIGH


To fix the issue, we will add a permissions block to the workflow. Since the workflow primarily involves scanning source code and Docker images, it does not require write permissions. We will set the contents permission to read at the workflow level, which will apply to all jobs unless overridden. This ensures that the GITHUB_TOKEN has the minimal permissions necessary to perform the tasks.

seanmorley15 and others added 20 commits June 20, 2025 09:30

Implement code changes to enhance functionality and improve performance

4bc7f3b

Update nl.json

0723ad7

Fix Dutch translations.

Merge pull request #694 from Ycer0n/patch-1

dc67ad1

Update nl.json

feat(security): add Trivy security scans for Docker images and source…

12a5221

… code

feat(security): restructure Trivy scans for improved clarity and orga…

d865454

…nization

fix(dependencies): update Django version to 5.2.2

5026243

style(workflows): standardize quotes and fix typo in frontend-test.yml

d797095

feat(workflows): add job names for clarity in backend and frontend te…

b8d30d2

…st workflows

refactor(workflows): remove path filters from pull_request and push t…

e335d7d

…riggers in backend and frontend workflows

feat(workflows): add paths to push and pull_request triggers for back…

00a6e67

…end and frontend workflows

refactor(workflows): simplify trigger paths for backend and frontend …

b6e5e4a

…workflows fix(dependencies): add overrides for esbuild in frontend package.json

fix(package): add missing pnpm overrides for esbuild in package.json

ed11d29

fix(workflows): add missing severity parameter for Trivy filesystem scan

b4407dc

fix(workflows): add missing severity parameter for Docker image scans…

6665422

… in Trivy workflow

fix(workflows): remove MEDIUM severity from Trivy scans in security w…

295ecd1

…orkflow

refactor(serializers): rename Location to Adventure and update relate…

c5639be

…d fields

refactor(serializers): rename Adventure to Location and update relate…

0566c71

…d fields

github-advanced-security bot found potential problems Jul 10, 2025

View reviewed changes

seanmorley15 closed this Jul 10, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Development #724

Development #724

Uh oh!

seanmorley15 commented Jul 10, 2025

Uh oh!

vercel bot commented Jul 10, 2025

Uh oh!

Check warning

Copilot Autofix

Check warning

Copilot Autofix

Uh oh!

@@ -14,2 +14,5 @@
+            permissions:
+              contents: read
             jobs:
@@ -36,2 +39,5 @@
                 runs-on: ubuntu-latest
+                permissions:
+                  contents: read
+                  packages: write

Uh oh!

Development #724

Development #724

Uh oh!

Conversation

seanmorley15 commented Jul 10, 2025

Uh oh!

vercel bot commented Jul 10, 2025

Uh oh!

Check warning

Copilot Autofix

Check warning

Copilot Autofix

Uh oh!