feat: upgrade the version of countries-states-cities-database #894
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@SubodhDahal is attempting to deploy a commit to the Sean Morley's Projects Team on Vercel. A member of the Team first needs to authorize it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First, I want to say that AdventureLog is an interesting project. I believe it will be useful for me and many others to track our adventures and trips, making it easy to look back on them in the future.
Overview
The latest version of the countries-states-cities-database database has corrected many location details. I thought it would be beneficial to use this updated version in AdventureLog as well. I modified
download-countries.pyto handle the new JSON structure introduced in version 3.0 of the database.Changes:
state['state_code']tostate['iso2']to match the new field naming in the upstream data sourceIn my tests, the existing functionality remains unchanged after my modifications.