93 support for SQLite #141

sebastianconcept · 2024-01-29T11:06:12Z

This PR update Mapless so it can be used in Pharo 11 and Pharo 10 making sure the CI is happy and coverage/regression detection is preserved.

As the changelog says:

Jan 29, 2024
===================================
* Added SQLite support.
* Added Pharo 10 and Pharo 11 support.
* Dropped Pharo 7 support. Last working version on Pharo 7 was v0.5.26
* Added badges to the README.md

Also reviewed the readme so more people can try it and get started.

…ode and also fixes 2 unrelated unit tests

codecov · 2024-01-29T11:54:58Z

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (6b65116) 56.67% compared to head (06d1585) 57.70%.

Files	Patch %	Lines
...pless-Memory-Core/MaplessMemoryRepository.class.st	90.69%	4 Missing ⚠️
...ess-Mongo-Core/MaplessMongoReplicaSetPool.class.st	0.00%	3 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop     #141      +/-   ##
===========================================
+ Coverage    56.67%   57.70%   +1.02%     
===========================================
  Files           31       31              
  Lines         4157     4161       +4     
===========================================
+ Hits          2356     2401      +45     
+ Misses        1801     1760      -41

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…aLimitOrNil sort:

paulwilke · 2024-01-30T16:49:51Z

Stupid me I closed it

sebastianconcept · 2024-01-30T16:54:13Z

@paulwilke careful padawan, the vergence in the force is so strong with you that GitHub buttons get clicked if you do not control the dark side well enough.

fgarau

all minor points commented in place

fgarau · 2024-01-30T15:40:07Z

README.md

 ---

+## Description
+
+Mapless is a schema-less persistence framework supporting multiple backends and offering a user-friendly API. For instance, querying Mapless objects involves a common family of methods, and there's no need to declare accessors and mutators. See [examples below](#examples).


Escribir es borrar -- siempre decia Leandro Caniglia
En la segunda linea podes sacar el "For instance," y se lee mejor.

fgarau · 2024-01-30T15:42:40Z

README.md

+
+Mapless is a schema-less persistence framework supporting multiple backends and offering a user-friendly API. For instance, querying Mapless objects involves a common family of methods, and there's no need to declare accessors and mutators. See [examples below](#examples).
+
+Designed to be schema-less, Mapless eliminates the need for schema maintenance and avoids any Object-Relational Mapping requirements.


Tambien eliminaria el "Designed to be schema-less," -- ya lo dijiste en el parrafo anterior

fgarau · 2024-01-30T15:44:29Z

README.md

 philosopherUser := User new
 	person: philosopher;
 	save.  

 "Query for that user by ID and get its person instance"
 aristotle := (User findId: philosopherUser id) person.
 ```
-## Installation
+## Install


mmhh "How to Install" o "Installation" me suenan mejor, no se.

fgarau · 2024-01-30T16:04:21Z

README.md

@@ -1,25 +1,34 @@
-![Mapless](./header.png)
+![Mapless](./hero.jpg)

 # Mapless

 Schema-less persistence for Smalltalk with support for multiple backends.


Me gusto el tag de la imagen "Obsenly simple object persistence" -- schema-less and offering support for multiple backends

@fgarau no te había preguntado pero justo estaba hablando sobre la tagline con @eMaringolo hace un ratito :)

fgarau · 2024-01-30T16:06:39Z

src/BaselineOfMapless/BaselineOfMapless.class.st

+
+	spec baseline: 'MongoTalk' with: [ 
+		spec
+			repository: 'github://pharo-nosql/mongotalk:v2.0/mc';


To discuss why a specific version is needed here (v2.0)

@fgarau as Mapless is used in production, all its dependencies need to be version pinned. Actually you reminded me we can pin a couple more! Thanks for commenting about it.

PS: MongoTalk 2.0 is needed for accessing MongoDB from Pharo 10 and 10

fgarau · 2024-01-30T17:55:26Z

src/Mapless-SQLite-Core/MaplessSQLiteClient.class.st

+	id := sqliteRow first.
+	maplessData := Json readFrom: sqliteRow values second readStream.
+	maplessData at: aMaplessRepository idPropertyName put: id.
+	^ Mapless fromJSONObject: maplessData in: aMaplessRepository


just wondering where the readStream would be closed.
if the readStream is on a String, then ignore the above comment.

@fgarau yes, the Json readFrom: is the only user of that stream

fgarau · 2024-01-30T17:56:22Z

src/Mapless-SQLite-Core/MaplessSQLiteClient.class.st

+	^ String
+		streamContents: [ :stream | 
+			stream
+				<<


not sure where the << is implemented -- looks a bit confusing to me

@fgarau it's a Pharo way to say nextPutAll: :)

fgarau · 2024-01-30T18:00:36Z

src/Mapless-SQLite-Core/MaplessSQLitePool.class.st

+]
+
+{ #category : #accessing }
+MaplessSQLitePool >> currentClientDynamicVariable [


mmh.. wouldn't it be better currentClientDynamicVariableClass

@fgarau yes it would! great catch

fgarau · 2024-01-30T18:03:24Z

src/Mapless-SQLite-Core/MaplessSQLitePool.class.st

+		nextPutAll:
+			'(' , self busyClients size asString , ' busy, '
+				, self idleClients size asString , ' idle @'
+				, databaseFilenameOrKeyword , ')'


since you have a stream, I would rather avoid concatenation and use cascading nextPutAll: messages

fgarau · 2024-01-30T18:05:57Z

src/Mapless-SQLite-Core/MaplessSQLitePool.class.st

+	"Removes any client that might be expired or unreacheable."
+
+	self busyClients copy do: [ :e | self ifUnavailablePurge: e ].
+	self idleClients copy do: [ :e | self ifUnavailablePurge: e ]


why copying the collection when you operate on the elements?
would this work?
(self busyClients , self idleClients) do: [:e | self ifUnavailablePurge: e].

@fgarau because ifUnavailablePurge: mutates the collection and you should never mutate a collection while iterating it?

…lass

sebastianconcept · 2024-01-30T19:41:41Z

Lovely

* 93 support for SQLite (#141) * Adjusts the baseline * WIP for testSimple * Comment improvment * testSimpleSave green * fixed more tests * fixes benchmark for sqlite * makes unqlite benchmarks work and using JSON for serialization * changelog entry * fixes findAll: * fixes SQLite dependency in the baseline * fixes escaping single quote for insert and update, removes obsolete code and also fixes 2 unrelated unit tests * removes unused code and adds class comments * working well with SQLite ^3.38 * adds testTruncate * adds truncateAll * adds databaseStartOn: double dispatching with sqlLiteDatabaseStart * updates method for Pharo 10 to run tests * upgrades MongoTalk * adds Pharo64-10 and drops Pharo 7 * milliseconds to milliSeconds * updates changelog, readme and CI * adds missing , * wider range of acceptance for the tests of the replica set load balancer * adjust unit test from Pharo 11 * Run CI only on push * remove unused method and poorly worded comments * covering #drop * covers existence detection * removes unused method * covers insert: * adds coverage to findAll: aMaplessClass where: someConditions limit: aLimitOrNil sort: * readme edit * instance creation convenience * readme edit * baseline default now is to load Memory and SQLite backends * readme edit * readme edit * renames currentClientDynamicVariable to currentClientDynamicVariableClass --------- Co-authored-by: Sebastian Sastre <[email protected]> * changelog edit --------- Co-authored-by: Sebastian Sastre <[email protected]>

sebastianconcept mentioned this pull request Jan 29, 2024

Current latest can't be loaded in Pharo 10 #139

Closed

Sebastian Sastre and others added 18 commits January 29, 2024 08:16

Adjusts the baseline

1431f33

WIP for testSimple

7183396

Comment improvment

7867dd3

testSimpleSave green

5a27326

fixed more tests

851b5d0

fixes benchmark for sqlite

f391cab

makes unqlite benchmarks work and using JSON for serialization

7eaa6a8

changelog entry

1377b0d

fixes findAll:

06f8dc6

fixes SQLite dependency in the baseline

b5a3dce

fixes escaping single quote for insert and update, removes obsolete c…

6909709

…ode and also fixes 2 unrelated unit tests

removes unused code and adds class comments

74e3186

working well with SQLite ^3.38

ef28a4a

adds testTruncate

72706ee

adds truncateAll

5ac8404

adds databaseStartOn: double dispatching with sqlLiteDatabaseStart

d1c2515

updates method for Pharo 10 to run tests

2441876

upgrades MongoTalk

c21dd99

sebastianconcept force-pushed the 93-Support-for-SQLite branch from ad0b441 to c21dd99 Compare January 29, 2024 11:31

sebastianconcept added 2 commits January 29, 2024 08:41

adds Pharo64-10 and drops Pharo 7

cc6e2b6

milliseconds to milliSeconds

3b678b2

sebastianconcept added 7 commits January 29, 2024 09:12

updates changelog, readme and CI

7b2e417

adds missing ,

2e4b985

wider range of acceptance for the tests of the replica set load balancer

c12c5db

Merge 2e4b985

34d9b01

adjust unit test from Pharo 11

c1665b4

Run CI only on push

270fd5d

remove unused method and poorly worded comments

8b79ca3

sebastianconcept self-assigned this Jan 29, 2024

sebastianconcept added enhancement New Functionality chore A maintenance or marginal improvement task labels Jan 29, 2024

sebastianconcept added 5 commits January 29, 2024 12:32

covering #drop

1ab67e9

covers existence detection

7d842cb

removes unused method

cb7bbbf

covers insert:

c6a54ba

adds coverage to findAll: aMaplessClass where: someConditions limit: …

f138928

…aLimitOrNil sort:

giolvani approved these changes Jan 29, 2024

View reviewed changes

sebastianconcept added 2 commits January 29, 2024 17:34

readme edit

9ed4ee9

instance creation convenience

90aa096

sebastianconcept force-pushed the 93-Support-for-SQLite branch from e19d4b6 to 3f36643 Compare January 29, 2024 22:26

readme edit

0f75590

sebastianconcept force-pushed the 93-Support-for-SQLite branch from 3f36643 to 0f75590 Compare January 29, 2024 22:31

sebastianconcept added 2 commits January 29, 2024 19:34

baseline default now is to load Memory and SQLite backends

3c9eeeb

readme edit

8dfa0f8

sebastianconcept mentioned this pull request Jan 30, 2024

Upgrade MongoTalk #113

Closed

eMaringolo approved these changes Jan 30, 2024

View reviewed changes

paulwilke closed this Jan 30, 2024

paulwilke reopened this Jan 30, 2024

paulwilke approved these changes Jan 30, 2024

View reviewed changes

fgarau approved these changes Jan 30, 2024

View reviewed changes

sebastianconcept added 2 commits January 30, 2024 15:45

readme edit

8523bcf

renames currentClientDynamicVariable to currentClientDynamicVariableC…

06d1585

…lass

sebastianconcept merged commit 57ae861 into develop Jan 30, 2024
4 checks passed

sebastianconcept deleted the 93-Support-for-SQLite branch January 30, 2024 20:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

93 support for SQLite #141

93 support for SQLite #141

sebastianconcept commented Jan 29, 2024 •

edited

Loading

codecov bot commented Jan 29, 2024 •

edited

Loading

paulwilke commented Jan 30, 2024

sebastianconcept commented Jan 30, 2024

fgarau left a comment

fgarau Jan 30, 2024

fgarau Jan 30, 2024

fgarau Jan 30, 2024

fgarau Jan 30, 2024

sebastianconcept Jan 30, 2024

fgarau Jan 30, 2024

sebastianconcept Jan 30, 2024

fgarau Jan 30, 2024

sebastianconcept Jan 30, 2024 •

edited

Loading

fgarau Jan 30, 2024

sebastianconcept Jan 30, 2024

fgarau Jan 30, 2024

sebastianconcept Jan 30, 2024

fgarau Jan 30, 2024

fgarau Jan 30, 2024

sebastianconcept Jan 30, 2024 •

edited

Loading

sebastianconcept commented Jan 30, 2024


		Mapless is a schema-less persistence framework supporting multiple backends and offering a user-friendly API. For instance, querying Mapless objects involves a common family of methods, and there's no need to declare accessors and mutators. See [examples below](#examples).

		Designed to be schema-less, Mapless eliminates the need for schema maintenance and avoids any Object-Relational Mapping requirements.

93 support for SQLite #141

93 support for SQLite #141

Conversation

sebastianconcept commented Jan 29, 2024 • edited Loading

codecov bot commented Jan 29, 2024 • edited Loading

Codecov Report

paulwilke commented Jan 30, 2024

sebastianconcept commented Jan 30, 2024

fgarau left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sebastianconcept Jan 30, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sebastianconcept Jan 30, 2024 • edited Loading

Choose a reason for hiding this comment

sebastianconcept commented Jan 30, 2024

sebastianconcept commented Jan 29, 2024 •

edited

Loading

codecov bot commented Jan 29, 2024 •

edited

Loading

sebastianconcept Jan 30, 2024 •

edited

Loading

sebastianconcept Jan 30, 2024 •

edited

Loading