Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

150 improve unit test coverage for mapless mongo core #160

Merged
merged 48 commits into from
Mar 4, 2024
Merged

150 improve unit test coverage for mapless mongo core #160

merged 48 commits into from
Mar 4, 2024

Conversation

sebastianconcept
Copy link
Owner

  • Renamed project packages
  • Added some unit tests
  • Removed a deprecated unused class
  • Adjusted some delays in time sensitive tests (for example the ones that depend on Redis PUBSUB)

@sebastianconcept
removes deprecated class
ddc08fa
@sebastianconcept
signaling MaplessClassNotFound when resolver can't find a class
67483ac
@sebastianconcept
adds coverage for translations:
66b9951
@sebastianconcept
adds coverage to default action for MaplessError
649aa4d
@sebastianconcept
adds testPrintsWeightedNodeInAUsefulWay
2ddfa7f
@sebastianconcept
adds testChangeWeightedNodeWeight
b461ffd
@sebastianconcept
fixes testMaplessErrorDefaultAction
d0eafcf 
pins mumez/PunQLite:v2.0.1
makes the Baseline to load all packages without forcing their units tests (thay can be loaded optionally)
@sebastianconcept
CI adjust
1af4808
@sebastianconcept
fixes unit-tests instructions for CI
37f56e2
@sebastianconcept
baseline fix
71978dc
@sebastianconcept
adjusted baseline
adb9398
@sebastianconcept
adjust Mapless-Memory in the baseline
deaa714
@sebastianconcept
adjusts CI instructions
ebcdf73
@sebastianconcept
adjusts baseline
7c431b4
@sebastianconcept
package rename
7da2af3
@sebastianconcept
renamed packages
05a77f3
@sebastianconcept
added renamed package
6c56ea8
@sebastianconcept
renamed package
89e94ec
@sebastianconcept
adjusted tests delays
793674c
@sebastianconcept
increased to 200ms
9816020
@sebastianconcept
removes problematic package
b38a122
@sebastianconcept
re-adds UnQLite
283b117
@sebastianconcept
increased delay for the CI
9b39c51
@sebastianconcept
added delay after unsubscribing in the test
6590b8a
@sebastianconcept
adjusted delays
6d337ef
@sebastianconcept
adjusting delays
1df300b
@sebastianconcept sebastianconcept added the chore A maintenance or marginal improvement task label Feb 28, 2024
@codecov Codecov
Copy link

codecov bot commented Feb 28, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 94.59459% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 83.57%. Comparing base (1c49597) to head (4367848).

Files Patch % Lines
src/Mapless-Base/Mapless.class.st 71.42% 2 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##           develop     #160       +/-   ##
============================================
+ Coverage    59.07%   83.57%   +24.50%     
============================================
  Files           31       31               
  Lines         4222     3897      -325     
============================================
+ Hits          2494     3257      +763     
+ Misses        1728      640     -1088

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sebastianconcept
Copy link
Owner Author

Is okay for you @paulwilke like this ? https://app.codecov.io/gh/sebastianconcept/Mapless/pull/160

We can do more in a next round

giolvani
giolvani approved these changes Mar 2, 2024
View reviewed changes
Copy link
Collaborator

@giolvani giolvani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

paulwilke
paulwilke approved these changes Mar 3, 2024
View reviewed changes
Copy link
Collaborator

@paulwilke paulwilke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

fgarau
fgarau reviewed Mar 3, 2024
View reviewed changes
Copy link
Collaborator

@fgarau fgarau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all good so far -- mostly category renaming, class renaming and changes to sunits

@sebastianconcept sebastianconcept self-assigned this Mar 4, 2024
@sebastianconcept sebastianconcept merged commit 2815872 into develop Mar 4, 2024
3 checks passed
@sebastianconcept sebastianconcept deleted the 150-Improve-unit-test-coverage-for-Mapless-Mongo-Core branch March 4, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fgarau fgarau fgarau left review comments

@nicwease nicwease nicwease approved these changes

@giolvani giolvani giolvani approved these changes

@paulwilke paulwilke paulwilke approved these changes

@eMaringolo eMaringolo Awaiting requested review from eMaringolo

Assignees

@sebastianconcept sebastianconcept

Labels
chore A maintenance or marginal improvement task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sebastianconcept @paulwilke @fgarau @giolvani @nicwease