Open
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates CI/CD pipeline components and configurations to use newer versions and remove outdated references. The changes modernize the GitHub Actions workflow by upgrading dependencies and adjusting Go version support.
- Updates GitHub Actions (checkout@v5, setup-go@v5, golangci-lint-action@v8) and golangci-lint version
- Removes Go 1.23.x support and adds Go 1.25.x for testing matrix
- Removes deprecated master branch references from workflow triggers
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/validate.yml | Updates action versions, adds Go setup with 1.25.x, removes master branch trigger |
| .github/workflows/test.yml | Updates checkout action, removes master branch trigger, updates Go version matrix |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Member
drakenclimber
left a comment
drakenclimber
left a comment
There was a problem hiding this comment.
LGTM
Acked-by: Tom Hromatka <[email protected]>
This upgrades some CI components: - various github actions used for CI - golangci-lint - go (removed 1.23.x, added 1.25.x) In addition to that, - make sure latest Go is used for linting action; - drop master branch from jobs as we don't have it. Signed-off-by: Kir Kolyshkin <[email protected]>
For some time, ARM64 is available for GHA, let's make use of it. Signed-off-by: Kir Kolyshkin <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This upgrades some CI components:
In addition to that,
Finally,