Skip to content

CONTRIBUTING: Drop Python 2 requirement #4713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 21, 2025

Conversation

holesch
Copy link
Contributor

@holesch holesch commented Apr 5, 2025

Not sure if this is correct, but it looks like scapy doesn't support Python 2 anymore (pyproject.toml has the Programming Language :: Python :: 3 :: Only classifier).

Since 246ad3f ("Drop six library (first batch)") scapy doesn't support
Python 2 anymore. Drop the requirement in CONTRIBUTING.md.
Copy link

codecov bot commented Apr 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.55%. Comparing base (8f9c7a6) to head (f48814a).
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4713      +/-   ##
==========================================
- Coverage   82.11%   78.55%   -3.56%     
==========================================
  Files         361      336      -25     
  Lines       86908    81701    -5207     
==========================================
- Hits        71365    64181    -7184     
- Misses      15543    17520    +1977     

see 288 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@gpotter2 gpotter2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR & sorry for the delay

@gpotter2 gpotter2 enabled auto-merge (squash) April 21, 2025 20:53
@gpotter2 gpotter2 disabled auto-merge April 21, 2025 21:07
@gpotter2 gpotter2 merged commit d215192 into secdev:master Apr 21, 2025
22 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants