Skip to content

bluetooth: Add version and company identifiers to local version commands #4716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

antoniovazquezblanco
Copy link
Contributor

Checklist:

  • If you are new to Scapy: I have checked CONTRIBUTING.md (esp. section submitting-pull-requests)
  • I squashed commits belonging together
  • I added unit tests or explained why they are not relevant
  • I executed the regression tests (using cd test && ./run_tests or tox)
  • If the PR is still not finished, please create a Draft Pull Request

Just adds more information to the HCI_Cmd_Complete_Read_Local_Version_Information packet :)

@antoniovazquezblanco antoniovazquezblanco force-pushed the hcilv branch 2 times, most recently from 8e01ee0 to dc0cb7e Compare April 8, 2025 18:31
Copy link

codecov bot commented Apr 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.11%. Comparing base (8f9c7a6) to head (42dc38e).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4716   +/-   ##
=======================================
  Coverage   82.11%   82.11%           
=======================================
  Files         361      361           
  Lines       86908    86910    +2     
=======================================
+ Hits        71365    71367    +2     
  Misses      15543    15543           
Files with missing lines Coverage Δ
scapy/layers/bluetooth.py 90.41% <ø> (+0.01%) ⬆️

... and 11 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@XenoKovah
Copy link
Contributor

It would probably be good to add a comment pointing to https://bitbucket.org/bluetooth-SIG/public/src/main/assigned_numbers/company_identifiers/company_identifiers.yaml where the company identifiers come from, so they can be more easily updated in the future (since they change very frequently).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants