Updated docs related to openvino

[Mash707]

resolves #25

[juntao]

Hello, I am a code review bot on flows.network. Here are my reviews of code commits in this PR.

---

Overall, this pull request includes several updates related to OpenVINO documentation and dependencies. Among the changes, there are a few potential issues and errors that need to be addressed.

The first potential problem is in the GitHub workflows where the script is not sourcing setupvars.sh after installing OpenVINO. This may cause issues with correctly setting up the environment variables.

Another potential problem is in the installation script where the paths for the ldconfig file are not updated to reflect the new OpenVINO version. The script still uses the paths for OpenVINO 2021, which can lead to confusion and potential errors.

In terms of important findings, the removal of unnecessary code related to inspecting and modifying the /etc/ld.so.conf file is a positive change that does not introduce any potential problems.

Additionally, the addition of links to the official OpenVINO documentation in multiple README files is a valuable contribution without any potential problems.

Lastly, the update to the Wasmedge version is straightforward, but it is essential to ensure compatibility and avoid any compatibility issues or regressions with the codebase.

Overall, this pull request includes a mix of useful updates and potential issues that need to be resolved.

Details

Commit 41f079b0669f0a99bdfcf4f0990e4248835e36f1

Key changes:

• Updated the OpenVINO version in the GitHub workflows for building OpenVINO models to "2023.0.0"
• Updated the OpenVINO installation instructions in the README and examples to use version "2023.0.0"

Potential problems:

• In the GitHub workflows, the script is not sourcing setupvars.sh after installing OpenVINO. This may cause issues with correctly setting up the environment variables.
• In the installation script, the paths for the ldconfig file are not updated to reflect the new OpenVINO version. The script still uses the paths for OpenVINO 2021.

Commit 5243f9a1dbd7cbc1ce5abc173274bfdd72c90861

Key changes:

• Removed unnecessary code related to inspecting and adding new paths to /etc/ld.so.conf file.

Potential problems:

• None.

Overall, this patch removes unnecessary code related to inspecting and modifying the /etc/ld.so.conf file. This removal does not introduce any potential problems.

Commit 9e20824ca6e1eb9b29a886d30431561cb27eeaef

Key changes:

• Added links to the official OpenVINO documentation in multiple README files

Potential problems:

• There are no potential problems in this patch. It is a simple update to include links to the official OpenVINO documentation.

Commit 081a5d319d03432c8c5b7449ec8eca19e0076c4c

Key Changes:

• Added links to official documentation in the README files of the following directories: openvino-mobilenet-image, openvino-mobilenet-raw, openvino-road-segmentation-adas.
• The links point to the WasmEdge Docs and OpenVINO 2023 installation guide.

Potential problems:

• No potential problems were identified in this patch.

Overall, this patch adds useful links to the official documentation, which will help developers with the OpenVINO installation process and provide additional resources for understanding the project. It is a straightforward and valuable contribution.

Commit 705f1062f994336dc0c485398bc7965d3873b99a

Key Changes:

• The patch updates the Wasmedge version from 0.13.1 to 0.13.2 in various files.

Potential Problems:

• There are no significant potential problems with this patch. It is a straightforward update to the Wasmedge version used in multiple files. However, it would be helpful to ensure that the new version 0.13.2 is compatible with the codebase and doesn't introduce any compatibility issues or regressions.

[Mash707]

Hii @hydai could you please review the the PR. Also I have a question regarding the install_openvino.sh, what is the purpose of the code written from line 19 to 28?

WasmEdge-WASINN-examples/scripts/install_openvino.sh

Lines 19 to 28 in 4f7ff0a

	echo "*** inspect /etc/ld.so.conf"
	cat /etc/ld.so.conf
	echo "*** add new paths to /etc/ld.so.conf"
	echo "include /etc/ld.so.conf.d/*.conf" >> /etc/ld.so.conf
	echo "/opt/intel/openvino_2021/deployment_tools/ngraph/lib/" >> /etc/ld.so.conf
	echo "/opt/intel/openvino_2021/deployment_tools/inference_engine/lib/intel64/" >> /etc/ld.so.conf
	echo "*** inspect /etc/ld.so.conf"
	cat /etc/ld.so.conf

[hydai]

Hii @hydai could you please review the the PR. Also I have a question regarding the install_openvino.sh, what is the purpose of the code written from line 19 to 28?

WasmEdge-WASINN-examples/scripts/install_openvino.sh

Lines 19 to 28 in 4f7ff0a

	echo "*** inspect /etc/ld.so.conf"
	cat /etc/ld.so.conf
	echo "*** add new paths to /etc/ld.so.conf"
	echo "include /etc/ld.so.conf.d/*.conf" >> /etc/ld.so.conf
	echo "/opt/intel/openvino_2021/deployment_tools/ngraph/lib/" >> /etc/ld.so.conf
	echo "/opt/intel/openvino_2021/deployment_tools/inference_engine/lib/intel64/" >> /etc/ld.so.conf
	echo "*** inspect /etc/ld.so.conf"
	cat /etc/ld.so.conf

These lines are registering the OpenVINO libraries because the previous ones are using a script to set related environments. Since we don't need to do this anymore when using the official API repo, we can remove them.

[Mash707]

Hii @hydai I removed those lines. Should we add links to openvino official documents and wasmedge docs or the changes I made are enough?

[hydai]

Hii @hydai I removed those lines. Should we add links to openvino official documents and wasmedge docs or the changes I made are enough?

Yes, please

[Mash707]

I have added links to the official openvino docs and WasmEdge docs in the readme files

[Mash707]

I have added docs links in the Readme.md files of each example also. Should we keep the docs links in each Readme.md file ?

[hydai]

LGTM. @apepkuss PTAL.

[hydai]

Looks like there is a conflict between this branch and the master branch. Please fix the conflicts.

[Mash707]

Looks like there is a conflict between this branch and the master branch. Please fix the conflicts.

is this for me to fix ?

[hydai]

You may need to pull/rebase your branch to fix the conflicts.

[Mash707]

You may need to pull/rebase your branch to fix the conflicts.

I tried pulling and rebasing my branch with master branch but the conflict is not fixed.

I used this for reference regarding pulling and rebasing https://stackoverflow.com/questions/7929369/how-to-rebase-local-branch-onto-remote-master.

[Mash707]

Hii @hydai I have resolved the conflict. The PR is now ready to be merged.

[apepkuss]

@Mash707 Please check the failed CI workflows and resolve the failures. Thanks!

[Mash707]

Hii @apepkuss , The workflow should work now because previously it was using wasmedge version 0.13.1 . I changed it to the latest release 0.13.2. The install script for openvino was updated in the 0.13.2 release.

[apepkuss]

@hydai @Mash707 LGTM. Thanks!