Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add iSHE algorithm to HEU #148

Merged
merged 31 commits into from
Aug 30, 2024
Merged

add iSHE algorithm to HEU #148

merged 31 commits into from
Aug 30, 2024

Conversation

Alec-xdu
Copy link
Contributor

@Alec-xdu Alec-xdu commented Aug 1, 2024

add a kind of symmetric homomorphic encryption algorithm

Copy link

github-actions bot commented Aug 1, 2024

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@Alec-xdu
Copy link
Contributor Author

Alec-xdu commented Aug 1, 2024

I have read the CLA Document and I hereby sign the CLA

@usafchn
Copy link
Member

usafchn commented Aug 2, 2024

@Alec-xdu 请加一个 README 介绍一下算法,如果有相关 paper 也记到 readme 里面,感谢

@Alec-xdu
Copy link
Contributor Author

Alec-xdu commented Aug 2, 2024

好的 收到

heu/algorithms/ishe/base.h Outdated Show resolved Hide resolved
heu/algorithms/ishe/base.h Outdated Show resolved Hide resolved
heu/algorithms/ishe/decryptor.h Outdated Show resolved Hide resolved
heu/algorithms/ishe/base.h Outdated Show resolved Hide resolved
heu/algorithms/ishe/base.h Outdated Show resolved Hide resolved
heu/algorithms/ishe/base.h Outdated Show resolved Hide resolved
heu/algorithms/ishe/he_kit.h Outdated Show resolved Hide resolved
heu/algorithms/ishe/he_kit.cc Outdated Show resolved Hide resolved
heu/algorithms/ishe/he_kit.cc Outdated Show resolved Hide resolved
heu/algorithms/ishe/ishe.h Outdated Show resolved Hide resolved
@usafchn
Copy link
Member

usafchn commented Aug 8, 2024

hi,我在 algorithm 下面建了个 incubator 文件夹,辛苦把整个 ishe 挪个位置吧,move 到 incubator/
https://github.com/secretflow/heu/tree/main/heu/algorithms/incubator

heu/algorithms/ishe/BUILD.bazel Outdated Show resolved Hide resolved
heu/algorithms/ishe/base.h Outdated Show resolved Hide resolved
heu/algorithms/ishe/base.cc Outdated Show resolved Hide resolved
heu/algorithms/ishe/base.cc Outdated Show resolved Hide resolved
heu/algorithms/incubator/ishe/he_kit.cc Outdated Show resolved Hide resolved
heu/algorithms/ishe/ishe.h Outdated Show resolved Hide resolved
heu/algorithms/incubator/ishe/README.md Show resolved Hide resolved
heu/algorithms/incubator/ishe/he_kit.cc Outdated Show resolved Hide resolved
heu/algorithms/ishe/base.h Outdated Show resolved Hide resolved
@Alec-xdu
Copy link
Contributor Author

好的 以上问题正在修改,public key在文献中可以对应到keygen中生成的public parameters,作用是相似的

@usafchn
Copy link
Member

usafchn commented Aug 12, 2024

好的 以上问题正在修改,public key在文献中可以对应到keygen中生成的public parameters,作用是相似的

可以把 PublicKey 重命名一下,让后 HeKit 整体引用

@Alec-xdu
Copy link
Contributor Author

又看了一下test部分的源码,ut部分已经可以通过了

Copy link

@qxzhou1010 qxzhou1010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

算法安全角度没问题了,宇文老师可以再确认一下

heu/algorithms/incubator/ishe/base.h Show resolved Hide resolved
heu/algorithms/incubator/ishe/encryptor.h Outdated Show resolved Hide resolved
heu/algorithms/incubator/ishe/BUILD.bazel Outdated Show resolved Hide resolved
heu/algorithms/incubator/ishe/base.cc Outdated Show resolved Hide resolved
heu/algorithms/incubator/ishe/base.cc Outdated Show resolved Hide resolved
heu/algorithms/incubator/ishe/base.cc Outdated Show resolved Hide resolved
heu/algorithms/incubator/ishe/base.cc Outdated Show resolved Hide resolved
heu/algorithms/incubator/ishe/base.h Outdated Show resolved Hide resolved
heu/algorithms/incubator/ishe/base.cc Outdated Show resolved Hide resolved
heu/algorithms/incubator/ishe/he_kit.cc Outdated Show resolved Hide resolved
heu/algorithms/incubator/ishe/he_kit.h Outdated Show resolved Hide resolved
heu/algorithms/incubator/ishe/he_kit.cc Show resolved Hide resolved
@usafchn
Copy link
Member

usafchn commented Aug 30, 2024

还有,我记得之前有个单测,为什么又删了。外层的统一测试覆盖不一定全,这里最好直接针对 iSHE 加一些测试

@Alec-xdu
Copy link
Contributor Author

移文件夹的时候删掉了,刚才这个commit加回来

@usafchn
Copy link
Member

usafchn commented Aug 30, 2024

@Alec-xdu 正文部分差不多了,UT 再加几个 case 覆盖一下就好了,感谢!

@Alec-xdu Alec-xdu requested a review from usafchn August 30, 2024 12:22
@usafchn usafchn merged commit 4ae7a20 into secretflow:main Aug 30, 2024
12 of 13 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 30, 2024
@usafchn
Copy link
Member

usafchn commented Aug 30, 2024

已合入

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants