-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add iSHE algorithm to HEU #148
Conversation
All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
@Alec-xdu 请加一个 README 介绍一下算法,如果有相关 paper 也记到 readme 里面,感谢 |
好的 收到 |
hi,我在 algorithm 下面建了个 incubator 文件夹,辛苦把整个 ishe 挪个位置吧,move 到 incubator/ |
好的 以上问题正在修改,public key在文献中可以对应到keygen中生成的public parameters,作用是相似的 |
可以把 PublicKey 重命名一下,让后 HeKit 整体引用 |
又看了一下test部分的源码,ut部分已经可以通过了 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
算法安全角度没问题了,宇文老师可以再确认一下
还有,我记得之前有个单测,为什么又删了。外层的统一测试覆盖不一定全,这里最好直接针对 iSHE 加一些测试 |
移文件夹的时候删掉了,刚才这个commit加回来 |
@Alec-xdu 正文部分差不多了,UT 再加几个 case 覆盖一下就好了,感谢! |
已合入 |
add a kind of symmetric homomorphic encryption algorithm