Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement required calls to inscribe service for BRC20 transfer #182

Merged

Conversation

victorkirov
Copy link
Member

@victorkirov victorkirov commented Jul 20, 2023

🔘 PR Type

What kind of change does this PR introduce?

  • Enhancement

📜 Background

This adds the calls to the Xverse inscribe api to enable 1 step BRC20 transfers.

Issue Link: ENG-2391

🔄 Changes

Does this PR introduce a breaking change?

  • Yes, Incompatible API changes
  • No, Adds functionality (backwards compatible)
  • No, Bug fixes (backwards compatible)

Changes:

  • Added calls to the inscribe service for brc20 transfer fee estimation, order creation and order execution.
  • No breaking changes

Impact:

  • With these endpoints we will be able to make 1-step brc20 transfers

✅ Review checklist

Please ensure the following are true before merging:

  • Code Style is consistent with the project guidelines.
  • Code is readable and well-commented.
  • No unnecessary or debugging code has been added.
  • Security considerations have been taken into account.
  • The change has been manually tested and works as expected.
  • Breaking changes and their impacts have been considered and documented.
  • Code does not introduce new technical debt or issues.

@victorkirov victorkirov self-assigned this Jul 20, 2023
@linear
Copy link

linear bot commented Jul 20, 2023

ENG-2391 Implement 1 step BRC-20 transfers

We need to call the new inscription service in order to perform 1-step BRC-20 transfers. This logic should go into core and the shared logic be used in the web extension and the mobile apps.

@victorkirov victorkirov marked this pull request as draft July 21, 2023 07:46
@victorkirov victorkirov mentioned this pull request Aug 1, 2023
1 task
@victorkirov victorkirov removed the request for review from yknl August 2, 2023 20:05
transactions/brc20.ts Outdated Show resolved Hide resolved
@victorkirov victorkirov marked this pull request as ready for review August 7, 2023 08:16
@github-actions
Copy link
Contributor

github-actions bot commented Aug 7, 2023

Test this PR with npm i @secretkeylabs/[email protected]

Copy link
Member

@teebszet teebszet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for answering my questions. lgtm

@victorkirov victorkirov merged commit d456ea3 into develop Aug 8, 2023
3 checks passed
@victorkirov victorkirov deleted the victor/eng-2391-implement-1-step-brc-20-transfers branch August 8, 2023 08:55
teebszet pushed a commit that referenced this pull request Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants