Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add utils for displaying Brc20 token transaction history #185

Merged
merged 6 commits into from
Aug 9, 2023

Conversation

Imamah-Zafar
Copy link
Contributor

🔘 PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Enhancement
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

📜 Background

We want to display the transaction history for BRC20 tokens.

Issue Link: https://linear.app/xverseapp/issue/ENG-2459/brc-20-display-transaction-history

🔄 Changes

Does this PR introduce a breaking change?

  • Yes, Incompatible API changes
  • No, Adds functionality (backwards compatible)
  • No, Bug fixes (backwards compatible)

Changes:
The PR uses the api endpoint /v1/ordinals/token/${token}/history/${address} to get the history for a user's token and includes a function to parse the response from api in order to be used by the extension.

🖼 Screenshot / 📹 Video

✅ Review checklist

Please ensure the following are true before merging:

  • Code Style is consistent with the project guidelines.
  • Code is readable and well-commented.
  • No unnecessary or debugging code has been added.
  • Security considerations have been taken into account.
  • The change has been manually tested and works as expected.
  • Breaking changes and their impacts have been considered and documented.
  • Code does not introduce new technical debt or issues.

Copy link
Contributor

@dhriaznov dhriaznov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2023

Test this PR with npm i @secretkeylabs/[email protected]

@teebszet teebszet merged commit 4244bc9 into develop Aug 9, 2023
3 checks passed
@teebszet teebszet deleted the imamahzafar/brc20-token-tx-history branch August 9, 2023 12:27
teebszet pushed a commit that referenced this pull request Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants