Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Featured Apps api utils #287

Merged
merged 8 commits into from
Feb 19, 2024
Merged

Featured Apps api utils #287

merged 8 commits into from
Feb 19, 2024

Conversation

m-aboelenein
Copy link
Member

@m-aboelenein m-aboelenein commented Nov 16, 2023 •
edited by dhriaznov
Loading

🔘 PR Type

What kind of change does this PR introduce?

  • Enhancement

📜 Background

Provide a brief explanation of why this pull request is needed. Include the problem you are solving or the functionality you are adding. Reference any related issues.

Issue Link: #[ENG-3261]
Context Link (if applicable):

🔄 Changes

Does this PR introduce a breaking change?

  • Yes, Incompatible API changes
  • No, Adds functionality (backwards compatible)
  • No, Bug fixes (backwards compatible)

Changes:

  • Added the getFeaturedDapps method which fetches the list of featured dapps

🖼 Screenshot / 📹 Video

✅ Review checklist

Please ensure the following are true before merging:

  • Code Style is consistent with the project guidelines.
  • Code is readable and well-commented.
  • No unnecessary or debugging code has been added.
  • Security considerations have been taken into account.
  • The change has been manually tested and works as expected.
  • Breaking changes and their impacts have been considered and documented.
  • Code does not introduce new technical debt or issues.

@dhriaznov dhriaznov marked this pull request as draft December 19, 2023 11:01
@dhriaznov dhriaznov self-assigned this Feb 7, 2024
@dhriaznov dhriaznov added the enhancement New feature or request label Feb 7, 2024
@dhriaznov dhriaznov marked this pull request as ready for review February 8, 2024 19:08
@dhriaznov dhriaznov requested review from victorkirov and jordankzf and removed request for abdulhaseeb4239 February 8, 2024 19:13
victorkirov
victorkirov reviewed Feb 9, 2024
View reviewed changes
api/xverse.ts Outdated Show resolved Hide resolved
victorkirov
victorkirov reviewed Feb 9, 2024
View reviewed changes
api/xverse.ts Outdated Show resolved Hide resolved
victorkirov
victorkirov previously requested changes Feb 9, 2024
View reviewed changes
Copy link
Member

@victorkirov victorkirov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs some fixes

@jordankzf jordankzf requested review from jordankzf, teebszet and dhriaznov and removed request for jordankzf February 15, 2024 10:09
@github-actions GitHub Actions
Copy link
Contributor

Test this PR with npm i --save-exact @secretkeylabs/[email protected]

@jordankzf jordankzf dismissed victorkirov’s stale review February 19, 2024 04:32

Concerns have been addressed

@jordankzf jordankzf merged commit 092c102 into develop Feb 19, 2024
3 checks passed
@jordankzf jordankzf deleted the mahmoud/eng-3261-expl-mob-1-xverse-featured-apps-api branch February 19, 2024 04:32
@github-actions github-actions bot mentioned this pull request Feb 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jordankzf jordankzf jordankzf approved these changes

@dhriaznov dhriaznov dhriaznov approved these changes

@victorkirov victorkirov Awaiting requested review from victorkirov

@teebszet teebszet Awaiting requested review from teebszet

Assignees

@dhriaznov dhriaznov

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@m-aboelenein @victorkirov @dhriaznov @jordankzf