Remove nonwitnessutxo injection on pre-sign input preparation

[victorkirov]

🔘 PR Type

What kind of change does this PR introduce?

• Bugfix

📜 Background

Ledger requires nonWitnessUtxo to be set for segwit inputs in order to not display the non-verified input warning message. However, adding the value results in a PSBT with a slightly different structure, which some integrating apps don't like and they reject the signed PSBT.

🔄 Changes

Does this PR introduce a breaking change?

• Yes, Incompatible API changes
• No, Adds functionality (backwards compatible)
• No, Bug fixes (backwards compatible)

Changes:

• We now only inject the nonWitnessUtxo value when manually adding inputs into transactions. This means that we won't add it when signing external PSBTs.

Impact:

• This should allow you to purchase from marketplaces again

✅ Review checklist

Please ensure the following are true before merging:

• Code Style is consistent with the project guidelines.
• Code is readable and well-commented.
• No unnecessary or debugging code has been added.
• Security considerations have been taken into account.
• The change has been manually tested and works as expected.
• Breaking changes and their impacts have been considered and documented.
• Code does not introduce new technical debt or issues.

[github-actions]

Test this PR with npm i --save-exact @secretkeylabs/[email protected]

[m-aboelenein]

This makes sense. LGTM 👍