WorkflowHub fixes #2194
Merged
WorkflowHub fixes #2194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
fbacall
commented
May 1, 2025
fbacall
commented
- Fixes issue parsing RO-Crate metadata with authors that have affiliation as an array
- Fixes issue where old files would not be cleared out when submitting new version as an RO-Crate
stuzart
approved these changes
May 2, 2025
| @@ -78,8 +78,12 @@ def extract_author(obj) | |||
| if affiliation.is_a?(String) | |||
| author[:affiliation] = affiliation | |||
| else | |||
| affiliation = affiliation.dereference if affiliation.respond_to?(:dereference) | |||
| author[:affiliation] = affiliation['name'] if affiliation && affiliation['name'].present? | |||
| affiliation = [affiliation] unless affiliation.is_a?(Array) | |||
There was a problem hiding this comment.
you can actually just do affiliation = Array(affiliation) to acheive the same thing, but I don't think it matters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.