Skip to content

Fix for collection resource_list_items with deleted contributor #2213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jun 12, 2025

Conversation

stuzart
Copy link
Member

@stuzart stuzart commented Jun 11, 2025

@stuzart stuzart added this to the 1.17.0 milestone Jun 11, 2025
@stuzart stuzart moved this to In review in SEEK 1.17.x Jun 11, 2025
@stuzart stuzart requested a review from Copilot June 11, 2025 13:49
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for a deleted_contributor field on file_templates and placeholders, updates schema/migrations, and adjusts tests and views to handle deleted contributors in collection list items.

  • Introduced deleted_contributor columns for new resource types and bumped schema version
  • Extended unit and integration tests to cover deleted‐contributor behavior
  • Updated collection item view to compact nil maintainers and use the dynamic “creators” label

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
test/unit/asset_test.rb Added new asset types (:placeholder, :file_template, etc.) to deleted_contributor unit test
test/integration/index_pages_test.rb Added integration test for list items when contributor is deleted (spelling needs correction)
test/functional/collections_controller_test.rb Updated controller tests for deleted contributors and creator labels (assert usage and labels need fixes)
db/schema.rb Bumped schema version and added deleted_contributor to tables
db/migrate/20250610150119_add_deleted_contributor_to_placeholder.rb Migration to add deleted_contributor to placeholders
db/migrate/20250610150132_add_deleted_contributor_to_file_template.rb Migration to add deleted_contributor to file_templates
app/views/collections/_resource_list_item.html.erb Compact nil maintainers and switch to human_attribute_name('creators') for the label

@stuzart stuzart merged commit d5a8432 into main Jun 12, 2025
24 checks passed
@github-project-automation github-project-automation bot moved this from In review to Done in SEEK 1.17.x Jun 12, 2025
@stuzart stuzart deleted the resource-list-items-deleted-contributor-2212 branch June 12, 2025 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants