Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

strdup and kstrdup: null pointer checks #617

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

SafeCoding233
Copy link

The lib func strdup and kstrdup may return null pointers on memory allocation failures.

I added checks for the unchecked calls to those two functions.

Specifically, for the four firmware.c files in different patches, the null pointer is actually checked by the caller function. But it lacks an error message that indicates what happened.

For utilities/aircrack-ng/src/aircrack-ng.c, the following API strsep can indeed handle NULL pointers, but the program would silently go wrong. So I added an explicit error message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants