strdup and kstrdup: null pointer checks #617
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The lib func
strdup
andkstrdup
may return null pointers on memory allocation failures.I added checks for the unchecked calls to those two functions.
Specifically, for the four
firmware.c
files in different patches, the null pointer is actually checked by the caller function. But it lacks an error message that indicates what happened.For
utilities/aircrack-ng/src/aircrack-ng.c
, the following APIstrsep
can indeed handle NULL pointers, but the program would silently go wrong. So I added an explicit error message.