Bug fixing php7 #28
Open
Bug fixing php7 #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Gesundheitsminister
commented
Nov 30, 2017
Gesundheitsminister
commented
- wrong mysqli links
- sql error on page copy
- session fix
Bringing fork up to date
* fixed sql error in fnc.con -> con_create_site_meta_from_idcatside
thinkh
requested changes
Dec 26, 2017
| @@ -356,7 +356,7 @@ function get_parent_directories($iddirectory, $idclient) { | |||
| // -> else: only $file is used as ID | |||
| // | |||
| function get_file($file, $idclient = '', $iddirectory = '', $type = 1) { | |||
| if (empty($file)) return ''; // missing fileid | |||
| if (empty($file)) return array(); // missing fileid | |||
There was a problem hiding this comment.
Why do you use array() instead of [] in this file (2 times)?
There was a problem hiding this comment.
I tried to be compatible to php < 5.4. I dont know if this still makes sense.
| @@ -730,15 +730,15 @@ function con_create_site_meta_from_idcatside($idclient, $idlang_current, $idcats | |||
| //create idside | |||
| $sql = "INSERT INTO ".$cms_db['side']." (idclient) VALUES ('$idclient')"; | |||
| $db->query($sql); | |||
| $idside_to = mysqli_insert_id($this->db->Link_ID); | |||
| $idside_to = mysqli_insert_id($GLOBALS['db']->Link_ID); | |||
There was a problem hiding this comment.
$this->db is not set in this function. $GLOBALS['db'] is reliable.
| @@ -938,7 +938,7 @@ function insert_cssrelation( $idcss, $idcssfile ) { | |||
| $sql = 'INSERT INTO ' . $cms_db['css_upl'] . ' (idcss, idupl) VALUES '; | |||
| $sql .= '(' . $idcss . ', ' . $idcssfile . ')'; | |||
| $db->query($sql); | |||
| return mysqli_insert_id($this->db->Link_ID); | |||
| return mysqli_insert_id($GLOBALS['db']->Link_ID); | |||
There was a problem hiding this comment.
Same here: Why not using $db->Link_ID?
There was a problem hiding this comment.
Same problem. $this->db is not accessible everywhere.
backend/inc/inc.mod_config.php
Outdated
| @@ -80,6 +80,7 @@ | |||
| mip_forms_ob_start(); | |||
| eval(' ?>' . $default); | |||
| $default_arr = mip_forms_get_array(); | |||
| //$cms_mod = empty($cms_mod) ? : $cms_mod; | |||
There was a problem hiding this comment.
I have removed it. Comes with the next update.
| @@ -172,6 +172,9 @@ function mip_forms_abstrakt($in, $input) | |||
| $spaces .= sprintf($mip_forms_tab['tab'], ' '); | |||
| } | |||
|
|
|||
| $mip_forms_tab['left_width'] = empty($mip_forms_tab['left_width']) ? 0 : $mip_forms_tab['left_width']; | |||
There was a problem hiding this comment.
It is important that $mip_forms_tab['left_width'] is initialised with an integer. PHP7 will miscalculate otherwise.
for some configurations.
for some configurations.
…it produces more problems than it solved * CHANGE: Removed Session fallback in local.php. Prevents showing session ids in Search engines.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.