Skip to content

[STRAT-5634] | Multistatus Support on Google Enhanced Conversions. #2853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Innovative-GauravKochar
Copy link
Contributor

@Innovative-GauravKochar Innovative-GauravKochar commented Apr 7, 2025

This pull request is to add multiStatus support on userList action of Google Enhanced Conversions.
JIRA TICKET:-https://segment.atlassian.net/jira/software/c/projects/STRATCONN/boards/310?assignee=63617339fc0cc7a600b03c6b&selectedIssue=STRATCONN-5634

Local Testing

Stage Testing completed successfully via Port Forwarding as users are not getting sync while creating audience in stage.

Stage Testing via Bulk Batching

Testing

Include any additional information about the testing you have completed to
ensure your changes behave as expected. For a speedy review, please check
any of the tasks you completed below during your testing.

  • Added unit tests for new functionality
  • Tested end-to-end using the local server
  • [If destination is already live] Tested for backward compatibility of destination. Note: New required fields are a breaking change.
  • [Segmenters] Tested in the staging environment
  • [Segmenters] [If applicable for this change] Tested for regression with Hadron.

Copy link

codecov bot commented Apr 7, 2025

Codecov Report

Attention: Patch coverage is 85.81560% with 20 lines in your changes missing coverage. Please review.

Project coverage is 78.49%. Comparing base (ac5259f) to head (6c52ab2).
Report is 26 commits behind head on main.

Files with missing lines Patch % Lines
...tinations/google-enhanced-conversions/functions.ts 85.40% 10 Missing and 10 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2853      +/-   ##
==========================================
+ Coverage   77.96%   78.49%   +0.53%     
==========================================
  Files        1042     1100      +58     
  Lines       19031    22148    +3117     
  Branches     3703     4559     +856     
==========================================
+ Hits        14838    17386    +2548     
- Misses       2892     3421     +529     
- Partials     1301     1341      +40     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Innovative-GauravKochar Innovative-GauravKochar marked this pull request as ready for review April 10, 2025 12:15
@Innovative-GauravKochar Innovative-GauravKochar requested a review from a team as a code owner April 10, 2025 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants