StackAdapt Audience Destination: Fix profile deletion query #3215

Vanessa-SSY · 2025-08-28T21:03:32Z

A summary of your pull request, including the what change you're making and why.

Testing

Include any additional information about the testing you have completed to
ensure your changes behave as expected. For a speedy review, please check
any of the tasks you completed below during your testing.

Added unit tests for new functionality
Tested end-to-end using the local server
[If destination is already live] Tested for backward compatibility of destination. Note: New required fields are a breaking change.
[Segmenters] Tested in the staging environment
[Segmenters] [If applicable for this change] Tested for regression with Hadron.

joe-ayoub-segment · 2025-08-29T06:36:47Z

packages/destination-actions/src/destinations/stackadapt-audiences/index.ts

+        label: "Advertiser ID",
+        description: "The StackAdapt advertiser ID to add the profile to. The value in this field field can also be overridden at the Action level via the Action field of the same name.",
+        type: 'string', 
+        required: true,


Should be required:false.

joe-ayoub-segment · 2025-08-29T06:37:35Z

packages/destination-actions/src/destinations/stackadapt-audiences/index.ts

+        description: "The StackAdapt advertiser ID to add the profile to. The value in this field field can also be overridden at the Action level via the Action field of the same name.",
+        type: 'string', 
+        required: true,
+        disabledInputMethods: ['literal', 'variable', 'function', 'freeform', 'enrichment'],


No need for this line. Customers can't map data from payloads anyway so you can delete this line.

joe-ayoub-segment · 2025-08-29T06:38:48Z

packages/destination-actions/src/destinations/stackadapt-audiences/index.ts

    const syncId = sha256hash(String(userId))
+    const advertiserId = settings.advertiser_id
+    if(!advertiserId) {
+      throw new InvalidAuthenticationError("Advertiser value must be provided in either the main Settings Advertiser field or at the Action level Advertiser field.")


Suggested change

throw new InvalidAuthenticationError("Advertiser value must be provided in either the main Settings Advertiser field or at the Action level Advertiser field.")

throw new InvalidAuthenticationError("To delete a user, the Advertiser field in Settings should be populated.")

Vanessa-SSY · 2025-08-29T13:43:46Z

Hi @joe-ayoub-segment, thanks for your comments. Is there a way to use a dynamic dropdown instead of input box for advertiserID in under Settings?

Vanessa-SSY · 2025-08-29T13:58:45Z

We will not enable onDelete if we can't have the dropdown for advertiserIds in a single place that can be referenced for both perform and onDelete. It's going to cause unnecessary confusion for our clients.

joe-ayoub-segment · 2025-09-01T08:03:02Z

Hi Vanessa, That makes sense. I take it the Integration is in use by customers already - is this correct? If it wasn't then we could simply delete the field from the Action and add the field to the main Settings. Best regards, Joe

…

On Fri, Aug 29, 2025 at 2:59 PM Vanessa Sun ***@***.***> wrote: *Vanessa-SSY* left a comment (segmentio/action-destinations#3215) <https://urldefense.com/v3/__https://github.com/segmentio/action-destinations/pull/3215*issuecomment-3237137089__;Iw!!NCc8flgU!eLMBQ3629KvTQV192H1epqWWSx0Ez_ABzSJ6ccnqwwKuQqL8Hpou5nBDOq2sA-tkRTp3vA4Hoh3WDIhyTlMUTtX70Q$> We will not enable onDelete if we can't have the dropdown for advertiserIds in a single place that can be referenced for both perform and onDelete. It's going to cause unnecessary confusion for our clients. — Reply to this email directly, view it on GitHub <https://urldefense.com/v3/__https://github.com/segmentio/action-destinations/pull/3215*issuecomment-3237137089__;Iw!!NCc8flgU!eLMBQ3629KvTQV192H1epqWWSx0Ez_ABzSJ6ccnqwwKuQqL8Hpou5nBDOq2sA-tkRTp3vA4Hoh3WDIhyTlMUTtX70Q$>, or unsubscribe <https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AK2F3MDCGYDH3WPMT7RAZ6T3QBMCZAVCNFSM6AAAAACFCUJPIOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTEMZXGEZTOMBYHE__;!!NCc8flgU!eLMBQ3629KvTQV192H1epqWWSx0Ez_ABzSJ6ccnqwwKuQqL8Hpou5nBDOq2sA-tkRTp3vA4Hoh3WDIhyTlN8nHxRpQ$> . You are receiving this because you were mentioned.Message ID: ***@***.***>

Vanessa-SSY · 2025-09-02T14:02:48Z

It's not in use by clients at the moment. The traffic is from our internal testing.
Could you help confirm if we can have the same dropdown for advertiserIds under Settings as the one we have now under Mappings UI? @joe-ayoub-segment

joe-ayoub-segment · 2025-09-02T15:01:48Z

It's not in use by clients at the moment. The traffic is from our internal testing. Could you help confirm if we can have the same dropdown for advertiserIds under Settings as the one we have now under Mappings UI? @joe-ayoub-segment

Ah OK if no customers are using it, we can just keep the advertiserIds field in Settings / authentication, and then delete the advertiserIds in the Mappings UI.

Vanessa-SSY · 2025-09-02T15:43:19Z

It's not in use by clients at the moment. The traffic is from our internal testing. Could you help confirm if we can have the same dropdown for advertiserIds under Settings as the one we have now under Mappings UI? @joe-ayoub-segment

Ah OK if no customers are using it, we can just keep the advertiserIds field in Settings / authentication, and then delete the advertiserIds in the Mappings UI.

Yes, we can surely do that but more importantly we want to keep the UI intuitive for clients. I tried to have the dropdown for advertiser IDs in Settings / authentication but it doesn't seem to work. If we can get the dropdown working, we would still prefer having it in the Mappings UI instead of an input box in Settings

joe-ayoub-segment · 2025-09-15T08:07:33Z

Hi @Vanessa-SSY ,
If you can get the dynamic dropdown working in the global setting then you should be good to go.
The pattern for implementing the dynamic dropdown for a global setting is a little different (not sure why, I apologise!).

Can you try something like this please?

  authentication: {
    scheme: 'custom',
    fields: {
      myDynamicField: {
        label: 'My Dynamic Field',
        description: 'This field loads options dynamically',
        type: 'string',
        required: true,
        dynamic: async (request, { settings }) => {
          // Make API call using current settings to fetch choices
          const response = await request('https://api.example.com/options')
          return {
            choices: response.data.map(item => ({
              label: item.name,
              value: item.id
            }))
          }
        }
      }
    }
  }

Vanessa-SSY · 2025-09-16T22:56:50Z

Hi @Vanessa-SSY , If you can get the dynamic dropdown working in the global setting then you should be good to go. The pattern for implementing the dynamic dropdown for a global setting is a little different (not sure why, I apologise!).

Can you try something like this please?
  authentication: {
    scheme: 'custom',
    fields: {
      myDynamicField: {
        label: 'My Dynamic Field',
        description: 'This field loads options dynamically',
        type: 'string',
        required: true,
        dynamic: async (request, { settings }) => {
          // Make API call using current settings to fetch choices
          const response = await request('https://api.example.com/options')
          return {
            choices: response.data.map(item => ({
              label: item.name,
              value: item.id
            }))
          }
        }
      }
    }
  }

I tried with the code you suggested above but still seeing advertiser ID under Basic Settings being a stale input box instead of a dropdown populated based on API key. Would we be able to populate the advertiser list if API key is being provided under the same tab? I added some logs in the dynamic but don't see it being triggered. I pushed my code for your reference. @joe-ayoub-segment

joe-ayoub-segment · 2025-09-17T07:46:14Z

Hi @Vanessa-SSY , If you can get the dynamic dropdown working in the global setting then you should be good to go. The pattern for implementing the dynamic dropdown for a global setting is a little different (not sure why, I apologise!).
Can you try something like this please?
  authentication: {
    scheme: 'custom',
    fields: {
      myDynamicField: {
        label: 'My Dynamic Field',
        description: 'This field loads options dynamically',
        type: 'string',
        required: true,
        dynamic: async (request, { settings }) => {
          // Make API call using current settings to fetch choices
          const response = await request('https://api.example.com/options')
          return {
            choices: response.data.map(item => ({
              label: item.name,
              value: item.id
            }))
          }
        }
      }
    }
  }
I tried with the code you suggested above but still seeing advertiser ID under Basic Settings being a stale input box instead of a dropdown populated based on API key. Would we be able to populate the advertiser list if API key is being provided under the same tab? I added some logs in the dynamic but don't see it being triggered. I pushed my code for your reference. @joe-ayoub-segment

Ah OK - I wouldn't worry about testing it in the testing tool. That tool is so out of date it hardly works. We're going to be building a new test tool.

One way you should be able to test it is to use Postman. When you start up the testing tool you will see a list of endpoints you can hit at your localhost:3000

For example:

If you call those endpoints you should be able to invoke the dynamic function that populates the dropdown list.

If you have any trouble with this please schedule a call with me - I'd be happy to figure it out in a working session. https://calendly.com/joe_ayoub

Thanks
Joe

Vanessa-SSY · 2025-09-17T19:02:45Z

Hi @Vanessa-SSY , If you can get the dynamic dropdown working in the global setting then you should be good to go. The pattern for implementing the dynamic dropdown for a global setting is a little different (not sure why, I apologise!).
Can you try something like this please?
  authentication: {
    scheme: 'custom',
    fields: {
      myDynamicField: {
        label: 'My Dynamic Field',
        description: 'This field loads options dynamically',
        type: 'string',
        required: true,
        dynamic: async (request, { settings }) => {
          // Make API call using current settings to fetch choices
          const response = await request('https://api.example.com/options')
          return {
            choices: response.data.map(item => ({
              label: item.name,
              value: item.id
            }))
          }
        }
      }
    }
  }
I tried with the code you suggested above but still seeing advertiser ID under Basic Settings being a stale input box instead of a dropdown populated based on API key. Would we be able to populate the advertiser list if API key is being provided under the same tab? I added some logs in the dynamic but don't see it being triggered. I pushed my code for your reference. @joe-ayoub-segment
Ah OK - I wouldn't worry about testing it in the testing tool. That tool is so out of date it hardly works. We're going to be building a new test tool.

One way you should be able to test it is to use Postman. When you start up the testing tool you will see a list of endpoints you can hit at your localhost:3000

For example:
If you call those endpoints you should be able to invoke the dynamic function that populates the dropdown list.
If you have any trouble with this please schedule a call with me - I'd be happy to figure it out in a working session. https://calendly.com/joe_ayoub

Thanks Joe

I have tried to use postman but still don't see the dynamic function being triggered. I would like to schedule a call with you some time tomorrow if that works for you. I'm free any time before 4PM EST. Please let me know you availability. @joe-ayoub-segment

fix profile deletion query

e298872

github-actions bot added deploy:push mode:cloud team:external labels Aug 28, 2025

joe-ayoub-segment reviewed Aug 29, 2025

View reviewed changes

joe-ayoub-segment self-assigned this Aug 29, 2025

joe-ayoub-segment added the partner-eng-review (cloud) label Aug 29, 2025

mark advertiser id as optional, change error msg

05d1fd7

use dynamic function to pull advertiser id

5112a42

Vanessa-SSY requested a review from joe-ayoub-segment September 18, 2025 18:01

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

StackAdapt Audience Destination: Fix profile deletion query #3215

StackAdapt Audience Destination: Fix profile deletion query #3215

Uh oh!

Vanessa-SSY commented Aug 28, 2025

Uh oh!

joe-ayoub-segment Aug 29, 2025

Uh oh!

joe-ayoub-segment Aug 29, 2025

Uh oh!

joe-ayoub-segment Aug 29, 2025

Uh oh!

Vanessa-SSY commented Aug 29, 2025

Uh oh!

Vanessa-SSY commented Aug 29, 2025

Uh oh!

joe-ayoub-segment commented Sep 1, 2025 via email

Uh oh!

Vanessa-SSY commented Sep 2, 2025 •

edited

Loading

Uh oh!

joe-ayoub-segment commented Sep 2, 2025

Uh oh!

Vanessa-SSY commented Sep 2, 2025 •

edited

Loading

Uh oh!

joe-ayoub-segment commented Sep 15, 2025

Uh oh!

Vanessa-SSY commented Sep 16, 2025 •

edited

Loading

Uh oh!

joe-ayoub-segment commented Sep 17, 2025

Uh oh!

Vanessa-SSY commented Sep 17, 2025

Uh oh!

Uh oh!

	throw new InvalidAuthenticationError("Advertiser value must be provided in either the main Settings Advertiser field or at the Action level Advertiser field.")
	throw new InvalidAuthenticationError("To delete a user, the Advertiser field in Settings should be populated.")

StackAdapt Audience Destination: Fix profile deletion query #3215

Are you sure you want to change the base?

StackAdapt Audience Destination: Fix profile deletion query #3215

Uh oh!

Conversation

Vanessa-SSY commented Aug 28, 2025

Testing

Uh oh!

joe-ayoub-segment Aug 29, 2025

Choose a reason for hiding this comment

Uh oh!

joe-ayoub-segment Aug 29, 2025

Choose a reason for hiding this comment

Uh oh!

joe-ayoub-segment Aug 29, 2025

Choose a reason for hiding this comment

Uh oh!

Vanessa-SSY commented Aug 29, 2025

Uh oh!

Vanessa-SSY commented Aug 29, 2025

Uh oh!

joe-ayoub-segment commented Sep 1, 2025 via email

Uh oh!

Vanessa-SSY commented Sep 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

joe-ayoub-segment commented Sep 2, 2025

Uh oh!

Vanessa-SSY commented Sep 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

joe-ayoub-segment commented Sep 15, 2025

Uh oh!

Vanessa-SSY commented Sep 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

joe-ayoub-segment commented Sep 17, 2025

Uh oh!

Vanessa-SSY commented Sep 17, 2025

Uh oh!

Uh oh!

Vanessa-SSY commented Sep 2, 2025 •

edited

Loading

Vanessa-SSY commented Sep 2, 2025 •

edited

Loading

Vanessa-SSY commented Sep 16, 2025 •

edited

Loading