Skip to content

Conversation

Prithviraj-rathore-segment
Copy link
Contributor

JIRA

https://twilio-engineering.atlassian.net/browse/STRATCONN-6153

A summary of your pull request, including the what change you're making and why.

Description

  1. This PR includes changes for migration from v3 to v4 for first party DV360 action destination .
  2. Updated the unit test cases to v4 from v3 in first party action destination .
  3. Google is depreciating the v3 version of dv360 hence the changes are done .

Testing

Please find the testing document attached here .
https://docs.google.com/document/d/1Y27nNeBh5qvqaTzIrG1i8CN1Yomhe6w6RmBUdfZ8Tzg/edit?tab=t.0

Include any additional information about the testing you have completed to
ensure your changes behave as expected. For a speedy review, please check
any of the tasks you completed below during your testing.

  • Added unit tests for new functionality
  • Tested end-to-end using the local server
  • [If destination is already live] Tested for backward compatibility of destination. Note: New required fields are a breaking change.
  • [Segmenters] Tested in the staging environment
  • [Segmenters] [If applicable for this change] Tested for regression with Hadron.

Copy link

codecov bot commented Sep 2, 2025

Codecov Report

❌ Patch coverage is 75.75758% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.70%. Comparing base (22c81b1) to head (c354345).
⚠️ Report is 18 commits behind head on main.

Files with missing lines Patch % Lines
...ns/src/destinations/first-party-dv360/functions.ts 75.75% 3 Missing and 5 partials ⚠️

❌ Your patch check has failed because the patch coverage (75.75%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3222      +/-   ##
==========================================
+ Coverage   79.62%   79.70%   +0.07%     
==========================================
  Files        1177     1184       +7     
  Lines       21703    21827     +124     
  Branches     4221     4251      +30     
==========================================
+ Hits        17282    17398     +116     
- Misses       3679     3685       +6     
- Partials      742      744       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants