[MAIN][STRATCONN-6153] : [DV360] added feature flag for first party dv360 destination for upgrade version from v3 to v4 #3283

Prithviraj-rathore-segment · 2025-09-16T13:56:09Z

JIRA

https://twilio-engineering.atlassian.net/browse/STRATCONN-6153

A summary of your pull request, including the what change you're making and why.

Description

This PR includes changes for migration from v3 to v4 for first party DV360 action destination with feature flag .
Updated the unit test cases to v4 from v3 in first party action destination with feature flag .
Google is depreciating the v3 version of dv360 hence the changes are done .

Testing

Please find the testing document attached here .
https://docs.google.com/document/d/1W8CsIjAtOyP27YrgfyHMLXSz5V2QvffG7t91wo05-QY/edit?tab=t.0

Flag created on production -

https://flagon.segment.com/families/centrifuge-destinations/gates/actions-first-party-dv360-version-update

Include any additional information about the testing you have completed to
ensure your changes behave as expected. For a speedy review, please check
any of the tasks you completed below during your testing.

Added unit tests for new functionality
Tested end-to-end using the local server
[If destination is already live] Tested for backward compatibility of destination. Note: New required fields are a breaking change.
[Segmenters] Tested in the staging environment
[Segmenters] [If applicable for this change] Tested for regression with Hadron.

…360 version from v3 to v4

codecov · 2025-09-16T14:01:27Z

Codecov Report

❌ Patch coverage is 95.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.00%. Comparing base (b67380e) to head (8a4631e).
⚠️ Report is 13 commits behind head on main.

Files with missing lines	Patch %	Lines
...ns/src/destinations/first-party-dv360/functions.ts	95.65%	0 Missing and 1 partial ⚠️
...t-party-dv360/removeFromAudMobileDeviceId/index.ts	50.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3283      +/-   ##
==========================================
+ Coverage   79.92%   80.00%   +0.08%     
==========================================
  Files        1193     1202       +9     
  Lines       21898    22096     +198     
  Branches     4262     4352      +90     
==========================================
+ Hits        17502    17679     +177     
+ Misses       3643     3639       -4     
- Partials      753      778      +25

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copilot

Pull Request Overview

This PR implements a feature flag migration from Google DV360 API v3 to v4 for the first-party DV360 destination. Google is deprecating the v3 API, requiring this upgrade to maintain functionality.

Key Changes

Added feature flag actions-first-party-dv360-version-update to control v3/v4 API usage
Updated all API endpoints to conditionally use v4 (firstPartyAndPartnerAudiences) or v3 (firstAndThirdPartyAudiences) based on feature flag
Comprehensive test coverage for both v3 and v4 API versions across all action types

Reviewed Changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 11 comments.

Show a summary per file

File	Description
`properties.ts`	Added feature flag constant definition
`index.ts`	Updated createAudience and getAudience to handle version-specific response fields
`functions.ts`	Modified API endpoint construction and response handling for v3/v4 compatibility
`addToAudContactInfo/index.ts`	Added features parameter to perform methods
`addToAudMobileDeviceId/index.ts`	Added features parameter to perform methods
`removeFromAudContactInfo/index.ts`	Added features parameter to perform methods
`removeFromAudMobileDeviceId/index.ts`	Added features parameter to perform methods
Test files	Comprehensive test coverage for both API versions with feature flag scenarios

Copilot · 2025-09-18T07:04:40Z

...on-actions/src/destinations/first-party-dv360/removeFromAudContactInfo/_tests_/index.test.ts

 })

-describe('First-Party-dv360.removeToAudContactInfo', () => {
+describe('First-Party-dv360.addToAudContactInfo', () => {


The test describe block name should be 'removeFromAudContactInfo' to match the actual action being tested, not 'addToAudContactInfo'.

Suggested change

describe('First-Party-dv360.addToAudContactInfo', () => {

describe('First-Party-dv360.removeFromAudContactInfo', () => {

Copilot · 2025-09-18T07:04:40Z

...on-actions/src/destinations/first-party-dv360/removeFromAudContactInfo/_tests_/index.test.ts

      .reply(200, { success: true })

-    const responses = await testDestination.testAction('removeFromAudContactInfo', {
+    const responses = await testDestination.testAction('addToAudContactInfo', {


These test calls should use 'removeFromAudContactInfo' action instead of 'addToAudContactInfo' since this is the remove action test file.

Suggested change

const responses = await testDestination.testAction('addToAudContactInfo', {

const responses = await testDestination.testAction('removeFromAudContactInfo', {

Copilot · 2025-09-18T07:04:40Z

...on-actions/src/destinations/first-party-dv360/removeFromAudContactInfo/_tests_/index.test.ts

      .reply(200, { success: true })

-    const responses = await testDestination.testAction('removeFromAudContactInfo', {
+    const responses = await testDestination.testAction('addToAudContactInfo', {


These test calls should use 'removeFromAudContactInfo' action instead of 'addToAudContactInfo' since this is the remove action test file.

Suggested change

const responses = await testDestination.testAction('addToAudContactInfo', {

const responses = await testDestination.testAction('removeFromAudContactInfo', {

Copilot · 2025-09-18T07:04:41Z

...on-actions/src/destinations/first-party-dv360/removeFromAudContactInfo/_tests_/index.test.ts

+      .reply(200, { success: true })
+
+    const events = createBatchTestEvents(createContactList)
+    const responses = await testDestination.testBatchAction('addToAudContactInfo', {


These test calls should use 'removeFromAudContactInfo' action instead of 'addToAudContactInfo' since this is the remove action test file.

Copilot · 2025-09-18T07:04:41Z

...on-actions/src/destinations/first-party-dv360/removeFromAudContactInfo/_tests_/index.test.ts

+      .reply(200, { success: true })
+
+    const events = createBatchTestEvents(createContactList)
+    const responses = await testDestination.testBatchAction('addToAudContactInfo', {


These test calls should use 'removeFromAudContactInfo' action instead of 'addToAudContactInfo' since this is the remove action test file.

Copilot · 2025-09-18T07:04:41Z

...on-actions/src/destinations/first-party-dv360/removeFromAudContactInfo/_tests_/index.test.ts


    expect(responses[0].options.body).toMatchInlineSnapshot(
-      '"{\\"advertiserId\\":\\"1234567890\\",\\"removedContactInfoList\\":{\\"contactInfos\\":[{\\"hashedEmails\\":\\"584c4423c421df49955759498a71495aba49b8780eb9387dff333b6f0982c777\\",\\"hashedPhoneNumbers\\":\\"422ce82c6fc1724ac878042f7d055653ab5e983d186e616826a72d4384b68af8\\",\\"zipCodes\\":\\"12345\\",\\"hashedFirstName\\":\\"96d9632f363564cc3032521409cf22a852f2032eec099ed5967c0d000cec607a\\",\\"hashedLastName\\":\\"799ef92a11af918e3fb741df42934f3b568ed2d93ac1df74f1b8d41a27932a6f\\",\\"countryCode\\":\\"US\\"}],\\"consent\\":{\\"adUserData\\":\\"CONSENT_STATUS_GRANTED\\",\\"adPersonalization\\":\\"CONSENT_STATUS_GRANTED\\"}}}"'
+      '"{\\"advertiserId\\":\\"1234567890\\",\\"addedContactInfoList\\":{\\"contactInfos\\":[{\\"hashedEmails\\":\\"584c4423c421df49955759498a71495aba49b8780eb9387dff333b6f0982c777\\",\\"hashedPhoneNumbers\\":\\"422ce82c6fc1724ac878042f7d055653ab5e983d186e616826a72d4384b68af8\\",\\"zipCodes\\":\\"12345\\",\\"hashedFirstName\\":\\"96d9632f363564cc3032521409cf22a852f2032eec099ed5967c0d000cec607a\\",\\"hashedLastName\\":\\"799ef92a11af918e3fb741df42934f3b568ed2d93ac1df74f1b8d41a27932a6f\\",\\"countryCode\\":\\"US\\"}],\\"consent\\":{\\"adUserData\\":\\"CONSENT_STATUS_GRANTED\\",\\"adPersonalization\\":\\"CONSENT_STATUS_GRANTED\\"}}}"'


The expected request body should contain 'removedContactInfoList' instead of 'addedContactInfoList' since this is testing the remove action.

Copilot · 2025-09-18T07:04:42Z

...on-actions/src/destinations/first-party-dv360/removeFromAudContactInfo/_tests_/index.test.ts

-    expect(responses[0].options.body).toBe(
-      '{"advertiserId":"1234567890","removedContactInfoList":{"contactInfos":[{"hashedEmails":"584c4423c421df49955759498a71495aba49b8780eb9387dff333b6f0982c777","hashedPhoneNumbers":"422ce82c6fc1724ac878042f7d055653ab5e983d186e616826a72d4384b68af8","zipCodes":"12345","hashedFirstName":"96d9632f363564cc3032521409cf22a852f2032eec099ed5967c0d000cec607a","hashedLastName":"799ef92a11af918e3fb741df42934f3b568ed2d93ac1df74f1b8d41a27932a6f","countryCode":"US"}],"consent":{"adUserData":"CONSENT_STATUS_GRANTED","adPersonalization":"CONSENT_STATUS_GRANTED"}}}'
+    expect(responses[0].options.body).toMatchInlineSnapshot(
+      '"{\\"advertiserId\\":\\"1234567890\\",\\"addedContactInfoList\\":{\\"contactInfos\\":[{\\"hashedEmails\\":\\"584c4423c421df49955759498a71495aba49b8780eb9387dff333b6f0982c777\\",\\"hashedPhoneNumbers\\":\\"422ce82c6fc1724ac878042f7d055653ab5e983d186e616826a72d4384b68af8\\",\\"zipCodes\\":\\"12345\\",\\"hashedFirstName\\":\\"96d9632f363564cc3032521409cf22a852f2032eec099ed5967c0d000cec607a\\",\\"hashedLastName\\":\\"799ef92a11af918e3fb741df42934f3b568ed2d93ac1df74f1b8d41a27932a6f\\",\\"countryCode\\":\\"US\\"}],\\"consent\\":{\\"adUserData\\":\\"CONSENT_STATUS_GRANTED\\",\\"adPersonalization\\":\\"CONSENT_STATUS_GRANTED\\"}}}"'


The expected request body should contain 'removedContactInfoList' instead of 'addedContactInfoList' since this is testing the remove action.

Suggested change

'"{\\"advertiserId\\":\\"1234567890\\",\\"addedContactInfoList\\":{\\"contactInfos\\":[{\\"hashedEmails\\":\\"584c4423c421df49955759498a71495aba49b8780eb9387dff333b6f0982c777\\",\\"hashedPhoneNumbers\\":\\"422ce82c6fc1724ac878042f7d055653ab5e983d186e616826a72d4384b68af8\\",\\"zipCodes\\":\\"12345\\",\\"hashedFirstName\\":\\"96d9632f363564cc3032521409cf22a852f2032eec099ed5967c0d000cec607a\\",\\"hashedLastName\\":\\"799ef92a11af918e3fb741df42934f3b568ed2d93ac1df74f1b8d41a27932a6f\\",\\"countryCode\\":\\"US\\"}],\\"consent\\":{\\"adUserData\\":\\"CONSENT_STATUS_GRANTED\\",\\"adPersonalization\\":\\"CONSENT_STATUS_GRANTED\\"}}}"'

'"{\\"advertiserId\\":\\"1234567890\\",\\"removedContactInfoList\\":{\\"contactInfos\\":[{\\"hashedEmails\\":\\"584c4423c421df49955759498a71495aba49b8780eb9387dff333b6f0982c777\\",\\"hashedPhoneNumbers\\":\\"422ce82c6fc1724ac878042f7d055653ab5e983d186e616826a72d4384b68af8\\",\\"zipCodes\\":\\"12345\\",\\"hashedFirstName\\":\\"96d9632f363564cc3032521409cf22a852f2032eec099ed5967c0d000cec607a\\",\\"hashedLastName\\":\\"799ef92a11af918e3fb741df42934f3b568ed2d93ac1df74f1b8d41a27932a6f\\",\\"countryCode\\":\\"US\\"}],\\"consent\\":{\\"adUserData\\":\\"CONSENT_STATUS_GRANTED\\",\\"adPersonalization\\":\\"CONSENT_STATUS_GRANTED\\"}}}"'

Copilot · 2025-09-18T07:04:42Z

...on-actions/src/destinations/first-party-dv360/removeFromAudContactInfo/_tests_/index.test.ts

+    expect(requestBody.addedContactInfoList.contactInfos.length).toBe(2)
+    expect(requestBody.addedContactInfoList.contactInfos[0].hashedEmails).toBeDefined()
+    expect(requestBody.addedContactInfoList.contactInfos[1].hashedEmails).toBeDefined()


These assertions should check 'removedContactInfoList' instead of 'addedContactInfoList' since this is testing the remove action.

Copilot · 2025-09-18T07:04:42Z

...on-actions/src/destinations/first-party-dv360/removeFromAudContactInfo/_tests_/index.test.ts

+    expect(requestBody.addedContactInfoList.contactInfos.length).toBe(2)
+    expect(requestBody.addedContactInfoList.contactInfos[0].hashedEmails).toBeDefined()
+    expect(requestBody.addedContactInfoList.contactInfos[1].hashedEmails).toBeDefined()


These assertions should check 'removedContactInfoList' instead of 'addedContactInfoList' since this is testing the remove action.

Copilot · 2025-09-18T07:04:42Z

...on-actions/src/destinations/first-party-dv360/removeFromAudContactInfo/_tests_/index.test.ts

+    expect(requestBody.addedContactInfoList.contactInfos.length).toBe(2)
+    expect(requestBody.addedContactInfoList.contactInfos[0].hashedEmails).toBeDefined()
+    expect(requestBody.addedContactInfoList.contactInfos[1].hashedEmails).toBeDefined()


These assertions should check 'removedContactInfoList' instead of 'addedContactInfoList' since this is testing the remove action.

Suggested change

expect(requestBody.addedContactInfoList.contactInfos.length).toBe(2)

expect(requestBody.addedContactInfoList.contactInfos[0].hashedEmails).toBeDefined()

expect(requestBody.addedContactInfoList.contactInfos[1].hashedEmails).toBeDefined()

expect(requestBody.removedContactInfoList.contactInfos.length).toBe(2)

expect(requestBody.removedContactInfoList.contactInfos[0].hashedEmails).toBeDefined()

expect(requestBody.removedContactInfoList.contactInfos[1].hashedEmails).toBeDefined()

Copilot

Pull Request Overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated no new comments.

…tInfo

Copilot

Pull Request Overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.

Copilot · 2025-09-18T09:37:25Z

...on-actions/src/destinations/first-party-dv360/removeFromAudContactInfo/_tests_/index.test.ts

 })

-describe('First-Party-dv360.removeToAudContactInfo', () => {
+describe('First-Party-dv360.removeFromAudContactInfo', () => {


The test description was corrected from 'removeToAudContactInfo' to 'removeFromAudContactInfo' to match the actual action name.

STRATCONN-6153 added feature flag changes for updating first party dv…

a268f1d

…360 version from v3 to v4

github-actions bot added mode:cloud team:segment labels Sep 16, 2025

joe-ayoub-segment added the not-partner-eng-review (cloud) label Sep 16, 2025

Prithviraj-rathore-segment marked this pull request as ready for review September 17, 2025 13:28

Prithviraj-rathore-segment requested a review from a team as a code owner September 17, 2025 13:28

github-actions bot requested a review from joe-ayoub-segment September 17, 2025 13:29

abhandage requested a review from Copilot September 18, 2025 07:01

Copilot AI reviewed Sep 18, 2025

View reviewed changes

STRATCONN-6153 fixed copilot comments for first party dv360

87639a9

Prithviraj-rathore-segment requested a review from Copilot September 18, 2025 08:01

Copilot AI reviewed Sep 18, 2025

View reviewed changes

STRATCONN-6153 fixed snapshot failing testcase in removeFromAudContac…

8a4631e

…tInfo

Prithviraj-rathore-segment requested a review from Copilot September 18, 2025 09:37

Copilot AI reviewed Sep 18, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[MAIN][STRATCONN-6153] : [DV360] added feature flag for first party dv360 destination for upgrade version from v3 to v4 #3283

[MAIN][STRATCONN-6153] : [DV360] added feature flag for first party dv360 destination for upgrade version from v3 to v4 #3283

Uh oh!

Prithviraj-rathore-segment commented Sep 16, 2025

Uh oh!

codecov bot commented Sep 16, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Sep 18, 2025

Uh oh!

Copilot AI Sep 18, 2025

Uh oh!

Copilot AI Sep 18, 2025

Uh oh!

Copilot AI Sep 18, 2025

Uh oh!

Copilot AI Sep 18, 2025

Uh oh!

Copilot AI Sep 18, 2025

Uh oh!

Copilot AI Sep 18, 2025

Uh oh!

Copilot AI Sep 18, 2025

Uh oh!

Copilot AI Sep 18, 2025

Uh oh!

Copilot AI Sep 18, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Sep 18, 2025

Uh oh!

Uh oh!

	describe('First-Party-dv360.addToAudContactInfo', () => {
	describe('First-Party-dv360.removeFromAudContactInfo', () => {

	const responses = await testDestination.testAction('addToAudContactInfo', {
	const responses = await testDestination.testAction('removeFromAudContactInfo', {

[MAIN][STRATCONN-6153] : [DV360] added feature flag for first party dv360 destination for upgrade version from v3 to v4 #3283

Are you sure you want to change the base?

[MAIN][STRATCONN-6153] : [DV360] added feature flag for first party dv360 destination for upgrade version from v3 to v4 #3283

Uh oh!

Conversation

Prithviraj-rathore-segment commented Sep 16, 2025

JIRA

Description

Testing

Flag created on production -

Uh oh!

codecov bot commented Sep 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Key Changes

Reviewed Changes

Uh oh!

Copilot AI Sep 18, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 18, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 18, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 18, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 18, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 18, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 18, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 18, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 18, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 18, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Copilot AI Sep 18, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

codecov bot commented Sep 16, 2025 •

edited

Loading