Skip to content

Conversation

@joe-ayoub-segment
Copy link
Contributor

change to how advanced matching works

Testing

Not needed. Not in use by customers.

@joe-ayoub-segment joe-ayoub-segment requested review from a team as code owners January 9, 2026 15:58
@joe-ayoub-segment joe-ayoub-segment self-assigned this Jan 9, 2026
@github-actions github-actions bot requested review from prayansh and silesky January 9, 2026 15:58
@joe-ayoub-segment joe-ayoub-segment changed the title [Facebook Pixel] - major refactor to fix advanced matching STRATCONN-5986 - [Facebook Pixel] - major refactor to fix advanced matching Jan 9, 2026
@codecov
Copy link

codecov bot commented Jan 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 31.86%. Comparing base (354c651) to head (44ced67).
⚠️ Report is 1 commits behind head on main.

❌ Your project status has failed because the head coverage (31.86%) is below the target coverage (70.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #3514       +/-   ##
===========================================
- Coverage   80.37%   31.86%   -48.52%     
===========================================
  Files        1528       15     -1513     
  Lines       29449      747    -28702     
  Branches     6298      125     -6173     
===========================================
- Hits        23670      238    -23432     
+ Misses       4914      509     -4405     
+ Partials      865        0      -865     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

itsarijitray
itsarijitray previously approved these changes Jan 12, 2026
@joe-ayoub-segment joe-ayoub-segment merged commit 8de8767 into main Jan 12, 2026
13 of 14 checks passed
@joe-ayoub-segment joe-ayoub-segment deleted the fbp-advanced-matching branch January 12, 2026 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants