Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove Event Delivery references #5049

Merged
merged 2 commits into from
Jul 26, 2023
Merged

Conversation

spencerattick
Copy link
Contributor

Proposed changes

Insert Function error information is not surfaced in the Event Delivery view contrary to what was originally published in our docs. A Functions engineer confirmed this: https://twilio.slack.com/archives/CH44TB529/p1689777484339219. Some customers have already expressed confusion about this so I'm removing the reference to Event Delivery until that functionality exists.

Merge timing

ASAP is fine

@spencerattick spencerattick requested a review from a team as a code owner July 20, 2023 18:35
@spencerattick spencerattick requested review from forstisabella and removed request for a team July 20, 2023 18:35
@forstisabella
Copy link
Contributor

Hi @spencerattick - looks like in the thread this is currently unsupported but will end up being supported in GA. Could we keep it in the docs as a comment, and then surface this info again after Insert Functions goes GA?

@spencerattick
Copy link
Contributor Author

Hey @forstisabella! Would keeping it in a comment keep it out of the public docs for now? If so then that sounds great! :) I'm not sure how to do that though. 😅

@forstisabella
Copy link
Contributor

forstisabella commented Jul 24, 2023

@spencerattick yep - it remains in the file but doesn't render for an end user to see! The site honors HTML comment formatting, so a comment could look like this:

<!--- I am a comment! --->

Or you can use the Liquid comment format:

{% comment %}

I am a comment!

{% endcomment %}

You can wrap a both kinds of comment formats around multiple lines of code.

@@ -237,12 +237,6 @@ Note the following limitations for batching with insert functions:

{% endcomment %}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{% comment %}

A function can throw errors, or Segment might encounter errors while invoking your function. You can view these errors in the [Event Delivery](/docs/connections/event-delivery/) tab for your Destination as in the example below.

![A screenshot of the event delivery tab, showing 519 failed events broken into categories explaining why they failed](images/event-delivery.png)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{% endcomment %}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! @forstisabella ! 🙌 I've added that section back in and wrapped it in comment syntax. :) Thanks for the help!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome @spencerattick!! Glad to hear it - I'll get this merged today and it'll go out with tomorrow's deploy :)

@forstisabella forstisabella merged commit 4d72979 into develop Jul 26, 2023
@forstisabella forstisabella deleted the spencerattick-patch-4 branch July 26, 2023 16:20
@github-actions
Copy link
Contributor

Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants