Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SF-1057: Update PrivateLink setup steps (new Databricks and Snowflake instructions) #7063

Merged
merged 6 commits into from
Sep 27, 2024

Conversation

AnnieZhao17
Copy link
Contributor

@AnnieZhao17 AnnieZhao17 commented Sep 23, 2024

Ticket: https://segment.atlassian.net/browse/SF-1057

Proposed changes

This PR updates the PrivateLink setup steps by:

  • Making the Databricks setup more complete, now that we have a better understanding after onboarding a customer
  • Aligning all sections to use similar phrasing
  • Adding the new Snowflake instructions now that we support it

Merge timing

  • ASAP once approved by both the segment-doc team and the PrivateLink engineers

Copy link

netlify bot commented Sep 23, 2024

Deploy Preview for segment-docs ready!

Name Link
🔨 Latest commit 6e205b7
🔍 Latest deploy log https://app.netlify.com/sites/segment-docs/deploys/66f5ac9a7d1d1200086d6285
😎 Deploy Preview https://deploy-preview-7063--segment-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@AnnieZhao17 AnnieZhao17 changed the title SF-1057: Update PrivateLink setup steps and limits (new Snowflake support) SF-1057: Update PrivateLink setup steps (new Databricks and Snowflake instructions) Sep 25, 2024
@AnnieZhao17 AnnieZhao17 marked this pull request as ready for review September 25, 2024 00:44
@AnnieZhao17 AnnieZhao17 requested a review from a team as a code owner September 25, 2024 00:44
sundareswarj
sundareswarj previously approved these changes Sep 25, 2024
Copy link
Contributor

@sundareswarj sundareswarj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spot checked some of the links in the rendered page, 👍

forstisabella
forstisabella previously approved these changes Sep 25, 2024
src/connections/aws-privatelink.md Outdated Show resolved Hide resolved
src/connections/aws-privatelink.md Outdated Show resolved Hide resolved
src/connections/aws-privatelink.md Outdated Show resolved Hide resolved
src/connections/aws-privatelink.md Outdated Show resolved Hide resolved
src/connections/aws-privatelink.md Outdated Show resolved Hide resolved

## Databricks

The following Databricks integrations support PrivateLink:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't we also support profile sync?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea we're supposed to also support Data Graph and Profiles Sync. They're even listed in our customer request template. When writing this integrations list the first time, we removed Data Graph and Profiles Sync because we hadnt tested it yet so we werent certain that it worked

wavetylor
wavetylor previously approved these changes Sep 26, 2024
@AnnieZhao17 AnnieZhao17 merged commit 85cc2f6 into develop Sep 27, 2024
4 checks passed
@AnnieZhao17 AnnieZhao17 deleted the sf-1057-setup branch September 27, 2024 16:26
Copy link
Contributor

Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants