-
Notifications
You must be signed in to change notification settings - Fork 683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use std::unordered_map instead of std::map #1285
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #1285 +/- ##
=======================================
Coverage 82.42% 82.42%
=======================================
Files 161 161
Lines 20764 20764
Branches 7846 7854 +8
=======================================
Hits 17115 17115
+ Misses 2993 2987 -6
- Partials 656 662 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@seladb ready for review. the only failed case is the CI issue. |
@seladb still happens, any idea? |
@tigercosmos maybe you need to change the CirrusCI image to |
@seladb should be fine now. |
Thank you @tigercosmos for working on this! I think we finally got rid of |
part of #977
changed
std::map
tostd::unordered_map
there are a few cases that still keep using
std::map
due to the original intention usage of thestd::map
properties.