Исправил ссылки в документации, требования CRAN.

selesnow · May 31, 2022 · 76b6673 · 76b6673
1 parent 9428d05
commit 76b6673
Show file tree

Hide file tree

Showing 21 changed files with 76 additions and 55 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -1,6 +1,6 @@
 Package: rgoogleads
 Title: Loading Data from 'Google Ads API'
-Version: 0.7.0
+Version: 0.7.1
 Authors@R: 
     c(person(given  = "Alexey",
              family = "Seleznev",
@@ -35,7 +35,7 @@ Imports: gargle (>= 1.2.0),
          rappdirs
 LazyData: true
 Roxygen: list(markdown = TRUE)
-RoxygenNote: 7.1.2
+RoxygenNote: 7.2.0
 Suggests: 
     rmarkdown,
     knitr,

diff --git a/NEWS.md b/NEWS.md
@@ -1,3 +1,6 @@
+# rgoogleads 0.7.1
+* Исправил ссылки на документацию к Google Ads API, с v8 на v10.
+
 # rgoogleads 0.7.0
 * Пакет переведён на работу с Google Ads API v10.
 * В блок `gads_utils.R` добавлена функция `gads_make_request()`, теперь это основная функция генерации HTTP запроса, она используется в остальных функциях для отправки запросов.

diff --git a/R/gads_customer.R b/R/gads_customer.R
@@ -8,7 +8,7 @@
 #'
 #' @return Google Ads customer data
 #'
-#' @seealso \href{https://developers.google.com/google-ads/api/rest/reference/rest/v8/customers/get}{Method: customers.get documentation}
+#' @seealso \href{https://developers.google.com/google-ads/api/rest/common/search}{Method: SearchStream documentation}
 #'
 #' @export
 gads_customer <- function(

diff --git a/R/gads_get_accessible_customers.R b/R/gads_get_accessible_customers.R
@@ -3,7 +3,7 @@
 #' @return List of your accessible accounts from top level
 #' @export
 #'
-#' @seealso \href{https://developers.google.com/google-ads/api/rest/reference/rest/v8/customers/listAccessibleCustomers}{Method: customers.listAccessibleCustomers documentation}
+#' @seealso \href{https://developers.google.com/google-ads/api/rest/reference/rest/v10/customers/listAccessibleCustomers}{Method: customers.listAccessibleCustomers documentation}
 #'
 #' @examples
 #' \dontrun{

diff --git a/R/gads_get_ad_group_criterions.R b/R/gads_get_ad_group_criterions.R
@@ -2,9 +2,9 @@
 #'
 #' @inheritParams gads_get_report
 #'
-#' @param fields character vector, list of report fields, all report has own fields list, for example \href{https://developers.google.com/google-ads/api/fields/v8/ad_group}{see field list of ad group report}.
+#' @param fields character vector, list of report fields, all report has own fields list, for example \href{https://developers.google.com/google-ads/api/fields/v10/ad_group}{see field list of ad group report}.
 #'
-#' @seealso \href{https://developers.google.com/google-ads/api/fields/v8/ad_group_criterion_query_builder}{Google Ads Query Builder}
+#' @seealso \href{https://developers.google.com/google-ads/api/fields/v10/ad_group_criterion_query_builder}{Google Ads Query Builder}
 #'
 #' @return tibble with ad group criterions dicrionary
 #' @export

diff --git a/R/gads_get_ad_groups.R b/R/gads_get_ad_groups.R
@@ -2,9 +2,9 @@
 #'
 #' @inheritParams gads_get_report
 #'
-#' @param fields character vector, list of report fields, all report has own fields list, for example \href{https://developers.google.com/google-ads/api/fields/v8/ad_group}{see field list of ad group report}.
+#' @param fields character vector, list of report fields, all report has own fields list, for example \href{https://developers.google.com/google-ads/api/fields/v10/ad_group}{see field list of ad group report}.
 #'
-#' @seealso \href{https://developers.google.com/google-ads/api/fields/v8/ad_group_query_builder}{Google Ads Query Builder}
+#' @seealso \href{https://developers.google.com/google-ads/api/fields/v10/ad_group_query_builder}{Google Ads Query Builder}
 #'
 #' @return tibble with ad group dicrionary
 #' @export

diff --git a/R/gads_get_ads.R b/R/gads_get_ads.R
@@ -1,9 +1,9 @@
 #' Get Ads Dictionary From Google Ads Client Account
 #'
 #' @inheritParams gads_get_report
-#' @param fields character vector, list pf report fields, all report has own fields list, for example \href{https://developers.google.com/google-ads/api/fields/v8/ad_group_ad}{see field list of ads report}.
+#' @param fields character vector, list pf report fields, all report has own fields list, for example \href{https://developers.google.com/google-ads/api/fields/v10/ad_group_ad}{see field list of ads report}.
 #'
-#' @seealso \href{https://developers.google.com/google-ads/api/fields/v8/ad_group_ad_query_builder}{Google Ads Query Builder}
+#' @seealso \href{https://developers.google.com/google-ads/api/fields/v10/ad_group_ad_query_builder}{Google Ads Query Builder}
 #' @return tibble with ads dicrionary
 #' @export
 #' @examples

diff --git a/R/gads_get_campaigns.R b/R/gads_get_campaigns.R
@@ -2,9 +2,9 @@
 #'
 #' @inheritParams gads_get_report
 #'
-#' @param fields character vector, list of report fields, all report has own fields list, for example \href{https://developers.google.com/google-ads/api/fields/v8/campaign}{see field list of campaigns report}.
+#' @param fields character vector, list of report fields, all report has own fields list, for example \href{https://developers.google.com/google-ads/api/fields/v10/campaign}{see field list of campaigns report}.
 #'
-#' @seealso \href{https://developers.google.com/google-ads/api/fields/v8/campaign_query_builder}{Google Ads Query Builder}
+#' @seealso \href{https://developers.google.com/google-ads/api/fields/v10/campaign_query_builder}{Google Ads Query Builder}
 #'
 #' @return tibble with campaings dicrionary
 #' @export

diff --git a/R/gads_get_report.R b/R/gads_get_report.R
@@ -1,7 +1,7 @@
 #' Get data from Google Ads API
 #'
-#' @param resource Report type, you can get list of all acessible resource using \code{\link{gads_get_metadata}}. For more information see \href{https://developers.google.com/google-ads/api/fields/v8/overview#list-of-all-resources}{link with list of all resources}
-#' @param fields character vector, list of report fields, all report has own fields list. You can get list of accesible resource fields using \code{\link{gads_get_fields}} for example \href{https://developers.google.com/google-ads/api/fields/v8/campaign}{see field list of campaign report}.
+#' @param resource Report type, you can get list of all acessible resource using \code{\link{gads_get_metadata}}. For more information see \href{https://developers.google.com/google-ads/api/fields/v10/overview#list-of-all-resources}{link with list of all resources}
+#' @param fields character vector, list of report fields, all report has own fields list. You can get list of accesible resource fields using \code{\link{gads_get_fields}} for example \href{https://developers.google.com/google-ads/api/fields/v10/campaign}{see field list of campaign report}.
 #' @param where Filter, for example you can filter campaigns by status \code{where = "campaign.status = 'ENABLED'"}.
 #' @param order_by Sorting, character vectors of fields and sorting directions, for example \code{order_by = c("campaign.name DESC", "metrics.clicks")}.
 #' @param limit Maximun rows in report
@@ -19,8 +19,8 @@
 #' @return tibble with the Google Ads Data.
 #' @seealso
 #' \itemize{
-#'   \item \href{https://developers.google.com/google-ads/api/fields/v8/overview}{Oficial Google Ads API Reports documantation}
-#'   \item \href{https://developers.google.com/google-ads/api/fields/v8/overview_query_builder}{Google Ads Query Builder}
+#'   \item \href{https://developers.google.com/google-ads/api/fields/v10/overview}{Oficial Google Ads API Reports documantation}
+#'   \item \href{https://developers.google.com/google-ads/api/fields/v10/overview_query_builder}{Google Ads Query Builder}
 #' }
 #' @export
 #'

diff --git a/R/rgoogleads_package.R b/R/rgoogleads_package.R
@@ -56,7 +56,7 @@
 #' \itemize{
 #'   \item \href{https://www.youtube.com/playlist?list=PLD2LDq8edf4qprTxRcflDwV9IvStiChHi}{YouTube lessons playlist}
 #'   \item \href{https://developers.google.com/google-ads/api/docs/start}{Oficial Google Ads API documantation}
-#'   \item \href{https://developers.google.com/google-ads/api/fields/v8/overview_query_builder}{Google Ads Query Builder}
+#'   \item \href{https://developers.google.com/google-ads/api/fields/v10/overview_query_builder}{Google Ads Query Builder}
 #'   \item \href{https://selesnow.github.io/rgoogleads/docs/}{rgoogleads home page}
 #' }
 #'

diff --git a/cran-comments.md b/cran-comments.md
@@ -1,5 +1,5 @@
 ## R CMD check results
 
-0 errors | 0 warnings | 1 note
+0 errors | 0 warnings | 0 note
 
-* Migrate to Google Ads API v10
+* update API documentation links.
diff --git a/man/gads_customer.Rd b/man/gads_customer.Rd
diff --git a/man/gads_get_accessible_customers.Rd b/man/gads_get_accessible_customers.Rd
diff --git a/man/gads_get_ad_group_criterions.Rd b/man/gads_get_ad_group_criterions.Rd
diff --git a/man/gads_get_ad_groups.Rd b/man/gads_get_ad_groups.Rd