Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Scheduled] flutter pub upgrade && flutter pub upgrade --major-versions #1562

Merged
merged 2 commits into from
Aug 17, 2023

Conversation

@codecov-commenter
Copy link

codecov-commenter commented Aug 17, 2023

Codecov Report

Merging #1562 (5d00e5b) into main (b1ceb8a) will increase coverage by 0.93%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1562      +/-   ##
==========================================
+ Coverage   93.61%   94.54%   +0.93%     
==========================================
  Files          52       52              
  Lines        1503     1503              
==========================================
+ Hits         1407     1421      +14     
+ Misses         96       82      -14     
Flag Coverage Δ
integration_test 70.59% <ø> (ø)
macos 89.87% <ø> (?)
ubuntu 93.61% <ø> (ø)
widget_test 90.82% <ø> (+1.01%) ⬆️
windows 89.87% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 4 files with indirect coverage changes

@sensuikan1973
Copy link
Owner Author

diff --git a/windows/runner/flutter_window.cpp b/windows/runner/flutter_window.cpp
index b25e363..955ee30 100644
--- a/windows/runner/flutter_window.cpp
+++ b/windows/runner/flutter_window.cpp
@@ -31,6 +31,11 @@ bool FlutterWindow::OnCreate() {
     this->Show();
   });
 
+  // Flutter can complete the first frame before the "show window" callback is
+  // registered. The following call ensures a frame is pending to ensure the
+  // window is shown. It is a no-op if the first frame hasn't completed yet.
+  flutter_controller_->ForceRedraw();
+
   return true;
 }

@sensuikan1973 sensuikan1973 merged commit d3e8d81 into main Aug 17, 2023
18 checks passed
@sensuikan1973 sensuikan1973 deleted the cron_upgrade_flutter_dependencies branch August 17, 2023 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants