-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade nodejs version #2269
Closed
Closed
upgrade nodejs version #2269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sensuikan1973
force-pushed
the
upgrade_nodejs_version
branch
from
November 1, 2024 16:30
612004f
to
b603873
Compare
$ ./typos . --config .github/.typos_config.toml
Warning: "Preferece" should be "Preference".
Warning: "Preferece" should be "Preference".
Warning: "Preferece" should be "Preference".
Warning: "Preferece" should be "Preference".
Warning: "Preferece" should be "Preference".
Warning: "Preferece" should be "Preference".
Warning: "Preferece" should be "Preference".
Warning: "Preferece" should be "Preference".
Warning: "Preferece" should be "Preference".
Warning: "Preferece" should be "Preference".
Warning: "Preferece" should be "Preference".
Warning: "Preferece" should be "Preference".
error: `Preferece` should be `Preference`
--> ./lib/app.dart:12:14
|
12 | const _sharedPrefereceWindowFrameWidthKey = 'windowFrameWidth';
| ^^^^^^^^^
|
error: `Preferece` should be `Preference`
--> ./lib/app.dart:13:14
|
13 | const _sharedPrefereceWindowFrameHeightKey = 'windowFrameHeight';
| ^^^^^^^^^
|
error: `Preferece` should be `Preference`
--> ./lib/app.dart:14:14
|
14 | const _sharedPrefereceWindowFrameLeftKey = 'windowFrameLeft';
| ^^^^^^^^^
|
error: `Preferece` should be `Preference`
--> ./lib/app.dart:15:14
|
15 | const _sharedPrefereceWindowFrameTopKey = 'windowFrameTop';
| ^^^^^^^^^
|
error: `Preferece` should be `Preference`
--> ./lib/app.dart:[43](https://github.com/sensuikan1973/pedax/actions/runs/11632762445/job/32396540321?pr=2269#step:3:45):34
|
43 | return pref.getDouble(_sharedPrefereceWindowFrameWidthKey);
| ^^^^^^^^^
|
error: `Preferece` should be `Preference`
--> ./lib/app.dart:48:34
|
48 | return pref.getDouble(_sharedPrefereceWindowFrameHeightKey);
| ^^^^^^^^^
|
error: `Preferece` should be `Preference`
--> ./lib/app.dart:[53](https://github.com/sensuikan1973/pedax/actions/runs/11632762445/job/32396540321?pr=2269#step:3:55):34
|
53 | return pref.getDouble(_sharedPrefereceWindowFrameLeftKey);
| ^^^^^^^^^
|
error: `Preferece` should be `Preference`
--> ./lib/app.dart:[58](https://github.com/sensuikan1973/pedax/actions/runs/11632762445/job/32396540321?pr=2269#step:3:60):34
|
58 | return pref.getDouble(_sharedPrefereceWindowFrameTopKey);
| ^^^^^^^^^
|
error: `Preferece` should be `Preference`
--> ./lib/app.dart:96:33
|
96 | await pref.setDouble(_sharedPrefereceWindowFrameWidthKey, windowInfo.frame.width);
| ^^^^^^^^^
|
error: `Preferece` should be `Preference`
--> ./lib/app.dart:97:33
|
97 | await pref.setDouble(_sharedPrefereceWindowFrameHeightKey, windowInfo.frame.height);
| ^^^^^^^^^
|
error: `Preferece` should be `Preference`
--> ./lib/app.dart:106:33
|
106 | await pref.setDouble(_sharedPrefereceWindowFrameLeftKey, windowInfo.frame.left);
| ^^^^^^^^^
|
error: `Preferece` should be `Preference`
--> ./lib/app.dart:107:33
|
107 | await pref.setDouble(_sharedPrefereceWindowFrameTopKey, windowInfo.frame.top);
| ^^^^^^^^^
| |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2269 +/- ##
==========================================
- Coverage 94.23% 94.17% -0.07%
==========================================
Files 52 52
Lines 1510 1510
==========================================
- Hits 1423 1422 -1
- Misses 87 88 +1
Flags with carried forward coverage won't be shown. Click here to find out more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Auto-generated by create-pull-request
See: https://github.com/peter-evans/create-pull-request/blob/master/docs/concepts-guidelines.md#triggering-further-workflow-runs