Skip to content

fix(tda): Fix and improve iOS scripts #844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

romtsn
Copy link

@romtsn romtsn commented Jun 5, 2025

This builds on top of #842 the diff should change after that one is merged to main

  • Use Appium 2.0 driver for ios tests
  • Add sleeps to ios_rn tests
  • Fix test_errors_list_ios as it was using non-existent identifiers and consistently failing
  • Use activate_app instead of launch_app as launch_app is being deprecated. Not sure if it's going to improve anything but better to not use outdated stuff I guess.

The test runs can be seen here: https://app.saucelabs.com/dashboard/tests?build=roman&platform=Android+13&platform=Android+11&platform=iOS+18&platform=iOS+17&platform=iOS+15.5&platform=iOS+15&platform=iOS+14.5&ownerId=myorganization&ownerType=organization&ownerName=My+organization&start=today

Copy link

vercel bot commented Jun 5, 2025

@romtsn is attempting to deploy a commit to the Sentry Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

codecov bot commented Jun 5, 2025

Bundle Report

Changes will increase total bundle size by 87.06kB (6.13%) ⬆️⚠️, exceeding the configured threshold of 5%.

Bundle name Size Change
empower-react-app-array-push 1.51MB 87.06kB (6.13%) ⬆️⚠️

Affected Assets, Files, and Routes:

view changes for bundle: empower-react-app-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/js/main.*.js 87.1kB 637.38kB 15.83% ⚠️
static/css/main.*.css -41 bytes 8.58kB -0.48%

Copy link

codecov bot commented Jun 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 27.86%. Comparing base (94b5eca) to head (e87c6a7).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #844   +/-   ##
=======================================
  Coverage   27.86%   27.86%           
=======================================
  Files          41       41           
  Lines        1055     1055           
  Branches      115      115           
=======================================
  Hits          294      294           
  Misses        742      742           
  Partials       19       19           
Flag Coverage Δ
api 6.63% <ø> (ø)
frontend 44.72% <ø> (ø)
Components Coverage Δ
checkout_module 6.63% <ø> (ø)
product_component 41.47% <ø> (ø)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant