Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FSN-29: Update forked repo with upstream changes #19

Open
wants to merge 364 commits into
base: master
Choose a base branch
from

Conversation

stefanoboriero
Copy link

The upstream repository https://github.com/banzaicloud/cloudinfo had some development since the time it was forked, mostly keeping dependencies up to date and updating cloud provider information, it would be good to incorporate these changes before adding our own on top

dependabot bot added 30 commits May 17, 2021 09:15
…ules/github.com/aliyun/alibaba-cloud-sdk-go-1.61.1091
…ules/github.com/aliyun/alibaba-cloud-sdk-go-1.61.1092
…ules/github.com/prometheus/common-0.25.0
…ules/github.com/aliyun/alibaba-cloud-sdk-go-1.61.1095
Bumps node from 16.1.0 to 16.2.0.

Signed-off-by: dependabot[bot] <[email protected]>
…ules/github.com/aliyun/alibaba-cloud-sdk-go-1.61.1099
…d_yarn/web/angular-devkit/build-angular-12.0.1
akijakya and others added 19 commits October 7, 2022 14:04
Reason: deprecated, will be removed in 2023-05-31.

Details: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

Command: grep -R -l "::set-output" . | xargs -n 1 sed -E -i '' 's/"?::set-output name=([^:]+)::([^"]+)"?$/"\1=\2" >> $GITHUB_OUTPUT/g'
…ated-gha-set-output

Replaced GHA `set-output` with `GITHUB_OUTPUT`
…ated-gha-set-output

Fixed GHA IFS handling in env var
@stefanoboriero stefanoboriero marked this pull request as draft January 8, 2025 13:20
Static analysis jobs for checking licenses and code linting are failing.
If we want them we would be better off starting form scratch with our
own standards rather than fixing what was in place.
@stefanoboriero stefanoboriero marked this pull request as ready for review January 9, 2025 09:14
@jordeu jordeu requested review from pabloaledo and jordeu January 14, 2025 09:13
@jordeu
Copy link
Member

jordeu commented Jan 14, 2025

There is a fork that seems more updated: https://github.com/wings-software/cloudinfo

Maybe we can check if it's worth to sync with that fork. WDYT?

Copy link

@pabloaledo pabloaledo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason to remove the linting steps from the Makefile and the CI pipeline?. Looks like useful. Was it too verbose or something similar?

@stefanoboriero
Copy link
Author

The main reason why I removed the linting was that the job was not working, and trying to fix it I realised that many of the linters used have gone deprecated in the meantime. I though that if we want some linting we should choose ourselves the one we want and have the same linters consistent across all our projects, rather than trying to align to what came with this repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants