Switch to pyproject.toml and UV #179
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamrtalbot
reviewed
Dec 19, 2024
There was a problem hiding this comment.
I'm not sold on the benefit here - what makes uv worth switching to? Especially when we have a dev flow?
Leave it to @ejseqera who will be the most affected by it.
Comment on lines
+42
to
+45
| #### uv workflow | ||
|
|
||
| 1. [Install uv](https://docs.astral.sh/uv/getting-started/installation/) | ||
| 2. `uv run seqerakit -h` |
There was a problem hiding this comment.
This is the developer document, could you elaborate on what you'd need to do to develop Seqera with uv? e.g. how do I add a new library as a dependency?
| @@ -64,7 +58,7 @@ jobs: | |||
| echo $GOOGLE_KEY | base64 -d > $temp_file | |||
| export GOOGLE_KEY=$temp_file | |||
|
|
|||
| seqerakit examples/yaml/e2e/*.yml --delete || true | |||
| uv run seqerakit examples/yaml/e2e/*.yml --delete || true | |||
There was a problem hiding this comment.
Need to update the vscode debugging instructions below to make sense. You have to set your python path to the uv created venv.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For after 0.5.0
pyproject.toml(I'm not sure if there's any drawbacks to this)